Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rad group switch doesn't print success message #7395

Closed
1 task
ytimocin opened this issue Mar 25, 2024 · 6 comments · Fixed by #7488
Closed
1 task

rad group switch doesn't print success message #7395

ytimocin opened this issue Mar 25, 2024 · 6 comments · Fixed by #7488
Assignees
@gpltaylor
Labels
bug Something is broken or not working as expected cli Work associated to the rad CLI good first issue Good for newcomers triaged This issue has been reviewed and triaged

Comments

@ytimocin
Copy link
Contributor

ytimocin commented Mar 25, 2024 •
edited by azure-boards bot
Loading

Steps to reproduce

  1. rad group create test
  2. rad group switch test
  3. See there is no message saying that the group was successfully switched

Observed behavior

image

Desired behavior

The CLI should tell me that the switch successfully happened.

Workaround

No response

rad Version

0.31

Operating system

No response

Additional context

No response

Would you like to support us?

  • Yes, I would like to support you

AB#11631
@ytimocin ytimocin added the bug Something is broken or not working as expected label Mar 25, 2024
@radius-triage-bot
Copy link

👋 @ytimocin Thanks for filing this bug report.

A project maintainer will review this report and get back to you soon. If you'd like immediate help troubleshooting, please visit our Discord server.

For more information on our triage process please visit our triage overview

@sylvainsf sylvainsf added good first issue Good for newcomers triaged This issue has been reviewed and triaged cli Work associated to the rad CLI labels Mar 25, 2024
@radius-triage-bot
Copy link

👍 We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@radius-triage-bot
Copy link

This issue is a great one to pickup for new contributors. It should only require small changes and not assume a deep knowledge of the Radius architecture.

We always welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@nicolejms
Copy link
Contributor

fit and finish. As good first issue, please add information on where the code is, etc. for new contributor.

@ytimocin
Copy link
Contributor Author

Here is where the logic of switching groups resides: https://github.com/radius-project/radius/blob/main/pkg/cli/cmd/group/groupswitch/switch.go. We need to do updates in this file but also shouldn't forget to create/update necessary unit and functional tests.

@gpltaylor
Copy link
Contributor

/assign

@gpltaylor gpltaylor mentioned this issue Apr 11, 2024
Merged
rynowak pushed a commit that referenced this issue Apr 14, 2024
@gpltaylor
rad group switch output (#7488)
4c23622 
# Description
rad cli group switch output to display success message when switching
output to a group

## Type of change
- This pull request fixes a bug in Radius and has an approved issue
(issue link required).

Fixes: #7395

---------

Signed-off-by: gpltaylor <gpltaylor@gmail.com>
sk593 pushed a commit that referenced this issue Apr 15, 2024
@gpltaylor @sk593
rad group switch output (#7488)
a8961ef 
# Description
rad cli group switch output to display success message when switching
output to a group

## Type of change
- This pull request fixes a bug in Radius and has an approved issue
(issue link required).

Fixes: #7395

---------

Signed-off-by: gpltaylor <gpltaylor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gpltaylor gpltaylor

Labels
bug Something is broken or not working as expected cli Work associated to the rad CLI good first issue Good for newcomers triaged This issue has been reviewed and triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rad group switch output gpltaylor/radius
4 participants
@sylvainsf @gpltaylor @ytimocin @nicolejms