Add workaround for proxy in front of API Server #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
commented
Jan 14, 2022
rynowak
commented
Jan 14, 2022
rynowak
commented
Jan 14, 2022
rynowak
commented
Jan 14, 2022
karolz-ms
approved these changes
Jan 14, 2022
|
Looks like there are still a few issues blocking tests. I'll keep this PR open and add the fixes here if they are straightforward. |
rynowak
force-pushed
the
rynowak/location-elation
branch
5 times, most recently
from
e972f7d
to
48dea70
Compare
One challenge of working with K3d (or similar) setups is that there is a proxy in front of the API Server (which is itself a proxy), but only one of these proxies is injecting Forwarded headers. This is a problem for us because the ARM-RPC protocol which we have to use on Azure requires a Absolute and Fully-Qualified URLs. Without the original scheme/host that is impossible for us. The fix here is to handle the Location header ourselves on the client and fix it up. This is a temporary fix and will only be needed while we're still using ARM-RPC as a protocol.
rynowak
force-pushed
the
rynowak/location-elation
branch
from
48dea70
to
9a5ef2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: radius-project/core-team#576
One challenge of working with K3d (or similar) setups is that there is a
proxy in front of the API Server (which is itself a proxy), but only one
of these proxies is injecting Forwarded headers.
This is a problem for us because the ARM-RPC protocol which we have
to use on Azure requires an Absolute and Fully-Qualified URLs. Without
the original scheme/host that is impossible for us.
The fix here is to handle the Location header ourselves on the client
and fix it up. This is a temporary fix and will only be needed while
we're still using ARM-RPC as a protocol.