Fix Delete application confirmation message points to the workspace but says environment #7089

[jhandel]

Signed-off-by: Josh josh@liveoak.ws

Description

Parse out the environment name from the Workspace.Environment property using the resources library.

Type of change

This pull request fixes a bug in Radius and has an approved issue

Fixes: #7089

[AaronCrawfis]

Thanks for the contribution @jhandel! For #7089, it's indeed a bug where it says "environment" when the value printed is the workspace name. Although, instead of updating the label I think it might be better to update the value to the environment name. We're trying to make workspaces an advanced concept that only need to be referenced/used if you need to opt-into the complexity of managing multiple environments/installations of Radius from a single machine. For the 99% case we want applications/environments to be the main resources and concepts users interact with.

I think a great solution to the bug in #7089 would be to update https://github.com/radius-project/radius/blob/main/pkg/cli/cmd/app/delete/delete.go#L146 to use the environment name instead of the workspace name, and keep the string as-is.

Thanks again for taking a crack at this! We do bi-weekly triage and you caught the issue before we could take a look at possible fixes and post a reply. Very much appreciate the pro-active fixes!

[jhandel]

Thanks for the contribution @jhandel! For #7089, it's indeed a bug where it says "environment" when the value printed is the workspace name. Although, instead of updating the label I think it might be better to update the value to the environment name. We're trying to make workspaces an advanced concept that only need to be referenced/used if you need to opt-into the complexity of managing multiple environments/installations of Radius from a single machine. For the 99% case we want applications/environments to be the main resources and concepts users interact with.

I think a great solution to the bug in #7089 would be to update https://github.com/radius-project/radius/blob/main/pkg/cli/cmd/app/delete/delete.go#L146 to use the environment name instead of the workspace name, and keep the string as-is.

Thanks again for taking a crack at this! We do bi-weekly triage and you caught the issue before we could take a look at possible fixes and post a reply. Very much appreciate the pro-active fixes!

Thanks for the feedback.. I have parsed out the environment name from the Workspace.Environment property using the resource parsing lib.

Though this brings up the question on if we should be adding env as an optional attribute to the delete command like resource group is. Just food for thought.

(also eventually I will figure out how to sign my commits properly from inside of VS code without having to do the rebase and force commit trick after messing it up lol... )

[shalabhms]

@jhandel - thanks for making the contribution . Could you please update the description which is pointing to your earlier commit changes?

[jhandel]

@jhandel - thanks for making the contribution . Could you please update the description which is pointing to your earlier commit changes?

done.... and thank you for the review of the PR.

[radius-functional-tests]

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	jhandel/radius
Commit ref	0f4e13f
Unique ID	3b4aadfb40
Image tag	pr-3b4aadfb40

Click here to see the list of tools in the current test run

• gotestsum 1.10.0
• KinD: v0.20.0
• Dapr: 1.12.0
• Azure KeyVault CSI driver: 1.4.2
• Azure Workload identity webhook: 1.1.0
• Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-3b4aadfb40
• Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
• applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-3b4aadfb40
• controller test image location: ghcr.io/radius-project/dev/controller:pr-3b4aadfb40
• ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-3b4aadfb40
• deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting samples functional tests...
⌛ Starting shared functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting ucp functional tests...
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ msgrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

[ytimocin]

Thanks for your contribution @jhandel !