-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: close file #7608
fix: close file #7608
Conversation
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7608 +/- ##
=======================================
Coverage 61.01% 61.02%
=======================================
Files 517 517
Lines 26511 26512 +1
=======================================
+ Hits 16176 16178 +2
Misses 8913 8913
+ Partials 1422 1421 -1 ☔ View full report in Codecov by Sentry. |
Hi @testwill! Thanks for this PR. I don't see an issue created for this bug. Would you like to go over the contributing docs and create one? Here is the link: https://github.com/radius-project/radius/blob/main/CONTRIBUTING.md. You can find very useful information on how to contribute to Radius. You should also sign your commit which is also explained in the contributing docs: https://github.com/radius-project/radius/blob/main/CONTRIBUTING.md#developer-certificate-of-origin. In the meantime, I will review, rebase this PR, and kick off the tests. |
Signed-off-by: guoguangwu <guoguangwug@gmail.com>
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Thanks for your contribution @testwill! Great find! |
Description
Please explain the changes you've made.
Type of change
Fixes: #issue_number