Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close file #7608

Merged
merged 1 commit into from
May 21, 2024
Merged

fix: close file #7608

merged 1 commit into from
May 21, 2024

Conversation

testwill
Copy link
Contributor

Description

Please explain the changes you've made.

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).
  • This pull request adds or changes features of Radius and has an approved issue (issue link required).
  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

@radius-functional-tests
Copy link

radius-functional-tests bot commented May 18, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository testwill/radius
Commit ref ba9c5e1
Unique ID func139d6f3d90
Image tag pr-func139d6f3d90
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func139d6f3d90
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func139d6f3d90
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func139d6f3d90
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func139d6f3d90
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting kubernetes functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting cli functional tests...
⌛ Starting samples functional tests...
⌛ Starting shared functional tests...
⌛ Starting ucp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting daprrp functional tests...
✅ kubernetes functional tests succeeded
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

Copy link

codecov bot commented May 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 61.02%. Comparing base (658dba7) to head (2c0813e).

Files Patch % Lines
pkg/cli/tools/binary_tools.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7608   +/-   ##
=======================================
  Coverage   61.01%   61.02%           
=======================================
  Files         517      517           
  Lines       26511    26512    +1     
=======================================
+ Hits        16176    16178    +2     
  Misses       8913     8913           
+ Partials     1422     1421    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ytimocin
Copy link
Contributor

Hi @testwill! Thanks for this PR. I don't see an issue created for this bug. Would you like to go over the contributing docs and create one? Here is the link: https://github.com/radius-project/radius/blob/main/CONTRIBUTING.md. You can find very useful information on how to contribute to Radius.

You should also sign your commit which is also explained in the contributing docs: https://github.com/radius-project/radius/blob/main/CONTRIBUTING.md#developer-certificate-of-origin.

In the meantime, I will review, rebase this PR, and kick off the tests.

pkg/cli/tools/binary_tools.go Outdated Show resolved Hide resolved
Signed-off-by: guoguangwu <guoguangwug@gmail.com>
@radius-functional-tests
Copy link

radius-functional-tests bot commented May 21, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository testwill/radius
Commit ref 2c0813e
Unique ID func16700ae912
Image tag pr-func16700ae912
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func16700ae912
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func16700ae912
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func16700ae912
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func16700ae912
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting shared functional tests...
⌛ Starting samples functional tests...
⌛ Starting ucp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting cli functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting datastoresrp functional tests...
✅ samples functional tests succeeded
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ cli functional tests succeeded
✅ shared functional tests succeeded
✅ datastoresrp functional tests succeeded

@ytimocin ytimocin merged commit 1a88d49 into radius-project:main May 21, 2024
16 checks passed
@ytimocin
Copy link
Contributor

Thanks for your contribution @testwill! Great find!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants