chore: clean code from bounded_vec remains (keep-starknet-strange#1113)

radiusxyz · Sep 18, 2023 · 0aa1f39 · 0aa1f39
1 parent b851410
commit 0aa1f39
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 12 deletions.
diff --git a/crates/pallets/starknet/src/lib.rs b/crates/pallets/starknet/src/lib.rs
@@ -432,7 +432,6 @@ pub mod pallet {
         EmitEventError,
         StateDiffError,
         ContractNotFound,
-        ReachedBoundedVecLimit,
         TransactionConversionError,
         SequencerAddressNotValid,
         InvalidContractClassForThisDeclareVersion,

diff --git a/crates/pallets/starknet/src/tests/invoke_tx.rs b/crates/pallets/starknet/src/tests/invoke_tx.rs
@@ -1,5 +1,5 @@
 use blockifier::abi::abi_utils::get_storage_var_address;
-use frame_support::{assert_err, assert_ok, bounded_vec};
+use frame_support::{assert_err, assert_ok};
 use mp_starknet::execution::types::Felt252Wrapper;
 use mp_starknet::transaction::compute_hash::ComputeTransactionHash;
 use mp_starknet::transaction::{InvokeTransaction, InvokeTransactionV1};
@@ -342,7 +342,7 @@ fn given_hardcoded_contract_run_invoke_on_argent_account_with_incorrect_signatur
         let none_origin = RuntimeOrigin::none();
 
         let mut transaction = get_invoke_argent_dummy();
-        transaction.signature = bounded_vec!(Felt252Wrapper::ONE, Felt252Wrapper::ONE);
+        transaction.signature = vec![Felt252Wrapper::ONE, Felt252Wrapper::ONE];
 
         let validate_result = Starknet::validate_unsigned(
             TransactionSource::InBlock,
@@ -385,7 +385,7 @@ fn given_hardcoded_contract_run_invoke_on_braavos_account_with_incorrect_signatu
         let none_origin = RuntimeOrigin::none();
 
         let mut transaction = get_invoke_braavos_dummy();
-        transaction.signature = bounded_vec!(Felt252Wrapper::ONE, Felt252Wrapper::ONE);
+        transaction.signature = vec![Felt252Wrapper::ONE, Felt252Wrapper::ONE];
 
         let validate_result = Starknet::validate_unsigned(
             TransactionSource::InBlock,

diff --git a/crates/primitives/starknet/src/block/mod.rs b/crates/primitives/starknet/src/block/mod.rs
@@ -4,20 +4,12 @@ mod header;
 use alloc::vec::Vec;
 
 pub use header::*;
-use sp_core::ConstU32;
 
 use crate::execution::types::Felt252Wrapper;
 use crate::traits::hash::HasherT;
 use crate::transaction::compute_hash::ComputeTransactionHash;
 use crate::transaction::Transaction;
 
-/// Block transactions max size
-// TODO: add real value (#250)
-pub type MaxTransactions = ConstU32<4294967295>;
-
-/// Maximum number of storage slots per contract
-pub type MaxStorageSlots = ConstU32<{ u32::MAX }>;
-
 /// Block Transactions
 pub type BlockTransactions = Vec<Transaction>;