[Tooltip] Fix tooltip visibility logic #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjenzz
commented
Dec 13, 2021
| } | ||
| window.clearTimeout(openTimerRef.current); |
There was a problem hiding this comment.
I think I was a bit too trigger happy when refactoring everything into this onChange handler after the original PR feedback because this was only clearing if the open value changed from false to true (or vice versa) which is incorrect:
CleanShot.2021-12-13.at.14.43.37.mp4
When the mouse enters, the open timer starts but open is still false, then the mouse leaves which calls setOpen(false) and because that is the current value, the open timer wasn't cleared.
jjenzz
commented
Dec 13, 2021
| }); | ||
| })} | ||
| onFocus={composeEventHandlers(props.onFocus, () => { | ||
| if (!isMouseDownRef.current) context.onOpen(); |
There was a problem hiding this comment.
Explicitly only open if it isn't a mousedown focus.
jjenzz
force-pushed
the
fix-tooltip
branch
2 times, most recently
from
8bafeef
to
3e8d9e8
Compare
| } | ||
| window.clearTimeout(openTimerRef.current); |
jjenzz
force-pushed
the
fix-tooltip
branch
3 times, most recently
from
70b594c
to
a1726e8
Compare
benoitgrelard
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of fixes here so I've left comments inline to clarify what's what.