[Slot] Fix children expectation when using Slottable
#1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@andy-hook Not approving the chromatic changes yet as I want to discuss them with you on a call first. |
andy-hook
reviewed
May 6, 2022
packages/react/slot/src/Slot.tsx
Outdated
Comment on lines
22
to
25
| if (React.Children.count(slottableChildren) > 1) return React.Children.only(null); | ||
| return React.isValidElement(slottableChildren) | ||
| ? (slottableChildren.props.children as React.ReactNode) | ||
| : null; |
There was a problem hiding this comment.
Is it worth us providing some comments to explain the flow here? the children of children is a bit of a mind bender without context. Hard to know if I'm finding it easier to follow simply because I already have that context.
There was a problem hiding this comment.
I've added comments but also re-wrote it a bit which I think makes it easier to read.
Let me know your thoughts: cb531c0
andy-hook
approved these changes
May 6, 2022
luisorbaiceta
pushed a commit
to luisorbaiceta/primitives
that referenced
this pull request
Jul 21, 2022
* [Slot] Fix children expectation when using Slottable Fixes radix-ui#1261 * Fix regression caught by Chromatic * Add tests * Replace with snapshot tests * PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1261