Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1306
The implementation is pretty much the same as what's in
Dialog
apart from the fact we don't need to map through the children ofPortal
because it doesn't have an overlay, only content.I did encounter a surprise though, which was that because of the
Popper
wrapper, the newly introducedPortal
didn't solve thezIndex
issue for users, as they could only set it on theContent
but not on its wrapper.I consulted with @jjenzz, we considered a few options:
<style>
tag mapping them so they could be overridenariakit
's playbook which is to copy thezIndex
from content onto the wrapper which means users only have to set it once and it just works.