Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tooltip] Expose Portal part #1427

Merged
merged 3 commits into from May 31, 2022
Merged

[Tooltip] Expose Portal part #1427

merged 3 commits into from May 31, 2022

Conversation

benoitgrelard
Copy link
Collaborator

@benoitgrelard benoitgrelard commented May 26, 2022 •
edited by andy-hook

Closes #1304

Warning: This is based on #1306 branch because of the changes in Popper.
We will need to be merged in correct order, and run version check too.

Note: Easier to review without whitespace

The implementation is the same as what's in Popover.

Warning
Breaking changes in docs:

  • new Portal part, with forceMount and container props, meaning default has changed (not portalled if not using new part)
  • lose portalled prop on Content
  • different default for forceMount on Content
  • manual z-index management
  • update demos/marketing comps

@benoitgrelard benoitgrelard added PR: Breaking Change This PR contains a breaking change PR: Documentation Needed This PR warrants a documentation update labels May 26, 2022
Base automatically changed from 1306-popover-portal to main May 31, 2022 08:29
@andy-hook andy-hook merged commit 8ed646a into main May 31, 2022
@andy-hook andy-hook deleted the 1304-tooltip-portal branch May 31, 2022 10:20
@benoitgrelard benoitgrelard mentioned this pull request Jun 8, 2022
Merged
luisorbaiceta pushed a commit to luisorbaiceta/primitives that referenced this pull request Jul 21, 2022
@benoitgrelard @andy-hook @luisorbaiceta
[Tooltip] Expose Portal part (radix-ui#1427)
a3d9ca2 
* [Tooltip] Expose `Portal` part

Closes radix-ui#1304

* [Tooltip] Add to SSR testing page

* Versions

Co-authored-by: Andy Hook <hello@andyhook.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-hook andy-hook andy-hook approved these changes

Assignees
No one assigned
Labels
PR: Breaking Change This PR contains a breaking change PR: Documentation Needed This PR warrants a documentation update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tooltip] Expose Portal part like in Dialog
2 participants
@benoitgrelard @andy-hook