Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popper] Allow more control over avoidCollisions #1683

Closed
wants to merge 1 commit into from
Closed

[Popper] Allow more control over avoidCollisions #1683

wants to merge 1 commit into from

Conversation

jgoz
Copy link

@jgoz jgoz commented Sep 22, 2022

Ref #1568.

Description

Expands the possible values for avoidCollisions to include the following:

  • auto — current behavior (as of 1.0.0) — Shift along the main axis and flip over the cross axis
  • flip — Flip along both axes, but don't shift
  • shift — Shift along the main axis only, but don't flip
  • off — disable collision avoidance

Boolean values are still accepted for compatibility:

  • trueauto
  • falseoff

I looked for Stories that would be appropriate to extend, but couldn't find any that demonstrated the shift+flip/auto behavior. Happy to add one if a maintainer pointed me in the right direction.

Open questions

  • In shift mode, should we set crossAxis: true? Or should flip and shift act as strict behavioral subsets of auto, per the current implementation?

@andy-hook
Copy link
Collaborator

thanks @jgoz , I left a follow up regarding similar options and wanted to share that sentiment here 🙏

@jgoz
Copy link
Author

jgoz commented Sep 23, 2022

Thanks @andy-hook! Feel free to close this PR to reduce noise. Looking forward to the solution you come up with

@andy-hook andy-hook added the PR: Under Consideration Has potentially wider implications which are being discussed label Sep 29, 2022
@jgoz jgoz closed this by deleting the head repository Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Under Consideration Has potentially wider implications which are being discussed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants