Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select] Add disabled prop to Root #1699

Merged
merged 4 commits into from Oct 10, 2022

Conversation

itsfaqih
Copy link
Contributor

@itsfaqih itsfaqih commented Oct 4, 2022

Description

This will add disabled prop to <Select.Root> to disable its trigger and the BubbleSelect when it's inside a form.
It's different from disabling the trigger only because the select value will not be submitted

image

@benoitgrelard
Copy link
Collaborator

Thanks for the contribution @itsfaqih, that makes a lot of sense regarding form submitting.
Could you run the version check and pick "minor" for select, you may need to run it again to pick "decline" on the top level project too.

@benoitgrelard benoitgrelard merged commit 0c8847c into radix-ui:main Oct 10, 2022
@itsfaqih itsfaqih deleted the select-add-disabled branch October 10, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants