[Popper] Add option to always re-position popper (rAF-based) #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitgrelard
added
the
PR: Under Consideration
benoitgrelard
added
PR: Documentation Needed
benoitgrelard
changed the title
benoitgrelard
changed the title
|
Thanks for your contribution @rynobax.
Yes I agree, I don't see many reason why anybody would disable some of the more optimised built-in positioning update, so really it's about opting-into a less optimised strategy for specific cases. I have reworked the API accordingly. |
benoitgrelard
approved these changes
Jun 5, 2023
This was referenced Jun 5, 2023
andy-hook
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow passing autoUpdateOptions to floating-ui, which allows using requestAnimationFrame to keep tooltip attached to element that is being moved programmatically. Not sure if this is the ideal API for enabling this behavior (maybe a boolean prop like
enableRequestAnimationFrameUpdateor something would be simpler), feel free to change.Originally asked about this here: #2006
Closes #1612
Closes #2006