Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DropdownMenu] Close the menu when mousing up outside #2150

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[DropdownMenu] Close the menu when mousing up outside #2150

wants to merge 2 commits into from

Conversation

joaom00
Copy link
Contributor

@joaom00 joaom00 commented May 22, 2023

As said in #657, I bring some improvements from Select like:

  • mousing up outside should close the menu

and this also Fixes #1620

joaom00
joaom00 commented Jul 5, 2023
View reviewed changes
packages/react/dropdown-menu/src/DropdownMenu.tsx
Comment on lines +214 to +215
if (!content.contains(event.target as HTMLElement)) {
onOpenChange(false);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should sub contents be taken into account?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitgrelard benoitgrelard Awaiting requested review from benoitgrelard

@andy-hook andy-hook Awaiting requested review from andy-hook

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DropdownMenu] First menu item is selected when trigger is clicked on mobile device
1 participant
@joaom00