[Slider] Fix step rounding issue #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjenzz
approved these changes
Feb 18, 2021
benoitgrelard
added a commit
that referenced
this pull request
Mar 3, 2021
# New features Breaking changes are indicated with a 🔥 icon. - Add support for SSR - [Accordion] Support multiple values (#527) 🔥 - [Tabs] Add RTL support (`dir` prop) (#497) - Remove `selector` prop and `data-radix-*` atributes 🔥 # Fixes - [Slider] Fix step rounding issue (#463) - [Presence] Improve `Presence` perf (#465) - Fixed potential issue with overriding attributes in certain primitives # Maintenance - Improved internal context handling - Better package/dependency split
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #462
@jjenzz this is what you get if you pass
step={0}and try and move it:NaNI think that's fine personally. It's pretty obvious it shouldn't work if you say that it goes by increments of
0.