Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ContextMenu] Add onOpenChange callback #604

Merged
merged 3 commits into from Apr 15, 2021
Merged

[ContextMenu] Add onOpenChange callback #604

merged 3 commits into from Apr 15, 2021

Conversation

jjenzz
Copy link
Contributor

@jjenzz jjenzz commented Apr 14, 2021

Description

We were missing this prop so that people can use the state to apply styles or whatever fancy stuffs they're up to 馃檪

benoitgrelard
benoitgrelard approved these changes Apr 15, 2021
View reviewed changes
Copy link
Collaborator

@benoitgrelard benoitgrelard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just modified the highlight to set it on the trigger as it was a bit weird to set it on the entire wrapper, otherwise all good!

@benoitgrelard benoitgrelard merged commit 0580f82 into main Apr 15, 2021
@benoitgrelard benoitgrelard deleted the context-menu-open-callback branch April 15, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitgrelard benoitgrelard benoitgrelard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jjenzz @benoitgrelard