[Polymorphic] Improve performance #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ran a quick test with
|
andy-hook
reviewed
Jul 19, 2021
| <As = IntrinsicElementString>( | ||
| props: As extends '' | ||
| ? { as: keyof JSX.IntrinsicElements } |
There was a problem hiding this comment.
Not super familiar with these typings. Is the gist that the conditionals are progressively narrowing from simple to more complex only as necessary?
There was a problem hiding this comment.
Yes, and we do this instead of checking As extends React.ElementType (for both types) because that breaks event typing for intrinsics.
Never used that before, TIL 😅 |
andy-hook
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's really hard to know for sure if tweaks to polymorphic types are improving performance but I picked a huge component (
ScrollArea) and recorded a video of me tweaking its types (with and without these changes) to show how TS is able to more quickly report issues now.The main change here is to remove the
extends keyof JSX.IntrinsicElementsfrom the generic which would have been slowing down all components regardless of whether theasprop was being used.Instead, I check to see if
asextends an empty string and if so, I type it askeyof JSX.IntrinsicElementsto enable intellisense when used.INTELLISENSE
CleanShot.2021-07-16.at.19.30.35.mp4
BEFORE (~8s)
CleanShot.2021-07-16.at.19.13.12.mp4
AFTER (~5s)
CleanShot.2021-07-16.at.19.14.08.mp4
I'll continue to think of ways to improve it further but this definitely feels better.