Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs] Unmount content when inactive #859

Merged
merged 1 commit into from
Sep 17, 2021
Merged

[Tabs] Unmount content when inactive #859

merged 1 commit into from
Sep 17, 2021

Conversation

jjenzz
Copy link
Contributor

@jjenzz jjenzz commented Sep 13, 2021 •
edited
Loading

Following up on this discussion #855 (comment)

Closes #813.

Adding this change for discussion.

@jjenzz jjenzz changed the title Unmount content when inactive [Tabs] Unmount content when inactive Sep 13, 2021
benoitgrelard
benoitgrelard approved these changes Sep 17, 2021
View reviewed changes
Copy link
Collaborator

@benoitgrelard benoitgrelard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks simple enough, did we test if it broke anything accessibility wise?

@jjenzz
Copy link
Contributor Author

jjenzz commented Sep 17, 2021

I tested in VoiceOver but just tested NVDA as well to make sure 😅 It works fine 👍

@jjenzz jjenzz merged commit 140701f into main Sep 17, 2021
@jjenzz jjenzz deleted the unmount-tab-content branch September 17, 2021 17:01
@benoitgrelard benoitgrelard mentioned this pull request Oct 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitgrelard benoitgrelard benoitgrelard approved these changes

@andy-hook andy-hook Awaiting requested review from andy-hook

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mount / Unmount of blurred tabs
2 participants
@jjenzz @benoitgrelard