Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Slider] Fix zero values issue #866

Merged
merged 1 commit into from Sep 16, 2021
Merged

[Slider] Fix zero values issue #866

merged 1 commit into from Sep 16, 2021

Conversation

benoitgrelard
Copy link
Collaborator

Fixes #865

I've added a Chromatic regression test for it too.

@benoitgrelard benoitgrelard mentioned this pull request Sep 15, 2021
Closed
jjenzz
jjenzz approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@jjenzz jjenzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet as a 🥜

@benoitgrelard benoitgrelard merged commit 0bc3898 into main Sep 16, 2021
@benoitgrelard benoitgrelard deleted the slider-fix branch September 16, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjenzz jjenzz jjenzz approved these changes

@andy-hook andy-hook Awaiting requested review from andy-hook andy-hook is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Slider] zero values do not display correctly when min is less than zero
2 participants
@benoitgrelard @jjenzz