Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ToggleGroup] Fix orientation a11y #965

Merged
merged 1 commit into from Nov 11, 2021
Merged

[ToggleGroup] Fix orientation a11y #965

merged 1 commit into from Nov 11, 2021

Conversation

jjenzz
Copy link
Contributor

@jjenzz jjenzz commented Nov 9, 2021 •
edited

Fixes #964

I've removed the aria-orientation from RovingFocusGroup and applied it in the relevant components instead.

jjenzz
jjenzz commented Nov 9, 2021
View reviewed changes
.yarn/versions/e0af1fb6.yml Outdated Show resolved Hide resolved
@jjenzz jjenzz changed the title [Toolbar] Fix orientation a11y [ToggleGroup] Fix orientation a11y Nov 9, 2021
@jjenzz jjenzz force-pushed the a11y-roving-aria-orientation branch 3 times, most recently from ccf7f2d to 9fc0829 Compare November 9, 2021 09:59
benoitgrelard
benoitgrelard approved these changes Nov 9, 2021
View reviewed changes
Copy link
Collaborator

@benoitgrelard benoitgrelard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like a sensible fix for the issue.

.yarn/versions/e0af1fb6.yml Outdated Show resolved Hide resolved
@jjenzz jjenzz force-pushed the a11y-roving-aria-orientation branch from 9fc0829 to 21c3915 Compare November 10, 2021 13:09
@jjenzz jjenzz force-pushed the a11y-roving-aria-orientation branch from 21c3915 to 38e4fa0 Compare November 10, 2021 13:10
@jjenzz jjenzz merged commit a5393c4 into main Nov 11, 2021
@jjenzz jjenzz deleted the a11y-roving-aria-orientation branch November 11, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitgrelard benoitgrelard benoitgrelard approved these changes

@andy-hook andy-hook Awaiting requested review from andy-hook andy-hook is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RovingFocusGroup] Incorrectly applies aria-orientation to some roles
2 participants
@jjenzz @benoitgrelard