New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Toast] New primitive docs #218
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/modulz/radix-website/7uniRXKT8fjGDYf5UFMfyzptfhwE |
jjenzz
commented
Aug 3, 2021
Nice one. Yeah I can create a demo for this 🚀 |
jjenzz
force-pushed
the
toast
branch
2 times, most recently
from
November 1, 2021 18:03
0486555
to
c3a4893
Compare
andy-hook
reviewed
Feb 23, 2022
benoitgrelard
added a commit
that referenced
this pull request
Feb 28, 2022
* Setup base PR * [Release] Add version files (#338) * [Release] Add `forwards` to animations (#339) * [Release] Add `forwards` to animations * Delete unnecessary version files * [Release] Add release notes (#337) * [Release] Add release notes * PR feedback * Update NavigationMenu PR id * [Release] Document `Dialog` labelling changes (#340) * [Release] Document Dialog labelling changes * PR feedback * Add beta badge (#341) * [Select] New primitive docs (#332) * [Select] New primitive docs * Add more examples * Update scrollarea composition example * Add demo * Update data/primitives/components/select/0.1.0.mdx Co-authored-by: Jenna Smith <jenna@modulz.app> * Add accessibility example reference * Add beta tag Co-authored-by: Jenna Smith <jenna@modulz.app> * [Release] Add note on labelling for `Select` (#343) * [NavigationMenu] New primitive docs (#333) * Initial `NavigationMenu` docs * Demo * Add beta badge, tweak examples * [Toast] New primitive docs (#218) * Add toast docs * Feedback from Colm * Updates * Rename `Region` to `Viewport` * Version and a11y updates * Copy tweaks * Copy updates * Add toast demo (rc) * Add export keyword to exports * Add beta badge * Update versions * [Toast] Fix data-attr and link (#344) * [NavigationMenu] Fix package installation typo (#346) * [NavigationMenu] Add indicator and router link examples (#345) * [NavigationMenu] Add and improve examples * Revert orientation demo change * Fix local link * [NavigationMenu] Use arrow as indicator in demo (#347) * [Release] Update release date (#342) * [Release] Update release date * Update release date * [Release] Update to latest versions (#348) Co-authored-by: Jenna Smith <jenna@modulz.app> Co-authored-by: Andy Hook <hello@andy-hook.co.uk> Co-authored-by: Jenna Smith <jenna@growldesign.co.uk> Co-authored-by: Mitul Shah <mitulxshah@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still needs a demo but covers all the other areas. It'd be good to see if @peduarte is able to create a demo from following these docs when he is back.
I've added more detail than we usually do in our accessibility and custom API sections.