fix: change default html element of MenuLabel, SelectLabel, ComboboxL…

…abel from `label` to `div` (#486) * fix: change default html element of `MenuLabel` from `label` to `div` * docs: align label prop with component implementations * fix: change default html element of `SelectLabel` from `label` to `div` * fix: change default html element of `ComboboxLabel` from `label` to `div`
radix-vue · Nov 2, 2023 · 4ef662e · 4ef662e
1 parent cbe4ea6
commit 4ef662e
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 8 deletions.
diff --git a/docs/content/components/combobox.md b/docs/content/components/combobox.md
@@ -594,7 +594,7 @@ Used to render the label of a group. It won't be focusable using arrow keys.
     {
       name: 'as',
       type: 'string | Component',
-      default: 'label',
+      default: 'div',
       description: 'The element or component this component should render as. Can be overwrite by <Code>asChild</Code>'
     },
     {

diff --git a/docs/content/components/context-menu.md b/docs/content/components/context-menu.md
@@ -506,7 +506,7 @@ Used to render a label. It won't be focusable using arrow keys.
     {
       name: 'as',
       type: 'string | Component',
-      default: 'label',
+      default: 'div',
       description: 'The element or component this component should render as. Can be overwrite by <Code>asChild</Code>'
     },
     {

diff --git a/docs/content/components/dropdown-menu.md b/docs/content/components/dropdown-menu.md
@@ -520,7 +520,7 @@ Used to render a label. It won't be focusable using arrow keys.
     {
       name: 'as',
       type: 'string | Component',
-      default: 'label',
+      default: 'div',
       description: 'The element or component this component should render as. Can be overwrite by <Code>asChild</Code>'
     },
     {

diff --git a/docs/content/components/menubar.md b/docs/content/components/menubar.md
@@ -650,7 +650,7 @@ Used to render a label. It won't be focusable using arrow keys.
     {
       name: 'as',
       type: 'string | Component',
-      default: 'label',
+      default: 'div',
       description: 'The element or component this component should render as. Can be overwrite by <Code>asChild</Code>'
     },
     {

diff --git a/docs/content/components/select.md b/docs/content/components/select.md
@@ -616,7 +616,7 @@ Used to render the label of a group. It won't be focusable using arrow keys.
     {
       name: 'as',
       type: 'string | Component',
-      default: 'label',
+      default: 'div',
       description: 'The element or component this component should render as. Can be overwrite by <Code>asChild</Code>'
     },
     {

diff --git a/packages/radix-vue/src/Combobox/ComboboxLabel.vue b/packages/radix-vue/src/Combobox/ComboboxLabel.vue
@@ -11,7 +11,7 @@ import { Primitive } from '@/Primitive'
 import { injectComboboxGroupContext } from './ComboboxGroup.vue'
 
 const props = withDefaults(defineProps<ComboboxLabelProps>(), {
-  as: 'label',
+  as: 'div',
 })
 
 const groupContext = injectComboboxGroupContext({ id: '' })

diff --git a/packages/radix-vue/src/Menu/MenuLabel.vue b/packages/radix-vue/src/Menu/MenuLabel.vue
@@ -8,7 +8,7 @@ export interface MenuLabelProps extends PrimitiveProps {}
 import { Primitive } from '@/Primitive'
 
 const props = withDefaults(defineProps<MenuLabelProps>(), {
-  as: 'label',
+  as: 'div',
 })
 </script>
 

diff --git a/packages/radix-vue/src/Select/SelectLabel.vue b/packages/radix-vue/src/Select/SelectLabel.vue
@@ -11,7 +11,7 @@ import { Primitive } from '@/Primitive'
 import { injectSelectGroupContext } from './SelectGroup.vue'
 
 const props = withDefaults(defineProps<SelectLabelProps>(), {
-  as: 'label',
+  as: 'div',
 })
 
 const groupContext = injectSelectGroupContext({ id: '' })