Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change default html element of MenuLabel from label to div #486

Merged
merged 5 commits into from
Nov 2, 2023
Merged

fix: change default html element of MenuLabel from label to div #486

merged 5 commits into from
Nov 2, 2023

Conversation

madebyfabian
Copy link
Contributor

Closes #482

@madebyfabian madebyfabian mentioned this pull request Nov 1, 2023
Closed
@zernonia
Copy link
Member

zernonia commented Nov 1, 2023

Thanks @madebyfabian ! Can you update the docs for ContextMenuLabel and MenubarLabel too 😁

@madebyfabian
Copy link
Contributor Author

madebyfabian commented Nov 2, 2023 •
edited

Hi there, so I wen't through all the code and found more inconsistencies where label was used instead of div. Now everything should be perfectly aligned.

  • DropdownMenu
    • docs
    • components
    • tests
  • ContextMenu
    • is currently different to react
    • docs
    • components → Basiert auf Menu/MenuLabel
    • tests
  • Menubar
    • is currently different to react
    • docs
    • components → Basiert auf Menu/MenuLabel
    • tests
  • Select
    • is currently different to react
    • docs
    • components
    • tests
  • Combobox
    • is currently different to react? → no, exclusive component
    • docs
    • components
    • tests

zernonia
zernonia approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @madebyfabian ! LGTM! 🚀

@zernonia zernonia merged commit 4ef662e into radix-vue:main Nov 2, 2023
2 of 3 checks passed
@madebyfabian madebyfabian deleted the menu-label-html-tag branch November 2, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zernonia zernonia zernonia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: MenuLabel rendered as <label>, should be <div>
2 participants
@madebyfabian @zernonia