refactor(Checkbox): check indeterminate state in click event handler (#…

…682) * fix(Checkbox): check indeterminate state in click event handler * fix: update failing test
radix-vue · Feb 13, 2024 · 6d8e21c · 6d8e21c
1 parent 7afe8c9
commit 6d8e21c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/radix-vue/src/Checkbox/Checkbox.test.ts b/packages/radix-vue/src/Checkbox/Checkbox.test.ts
@@ -90,7 +90,7 @@ describe('given checked value as "indeterminate"', async () => {
 
   it('should still be clickable', async () => {
     await wrapper.find('button').trigger('click')
-    expect(wrapper.find('button').attributes('data-state')).toBe('unchecked')
+    expect(wrapper.find('button').attributes('data-state')).toBe('checked')
   })
 })
 

diff --git a/packages/radix-vue/src/Checkbox/CheckboxRoot.vue b/packages/radix-vue/src/Checkbox/CheckboxRoot.vue
@@ -90,7 +90,7 @@ provideCheckboxRootContext({
     @keydown.enter.prevent="() => {
       // According to WAI ARIA, Checkboxes don't activate on enter keypress
     }"
-    @click="checked = !checked"
+    @click="checked = isIndeterminate(checked) ? true : !checked"
   >
     <slot />
   </Primitive>