fix(combobox): when backspacing searchTerm highlight the first available option #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble option from filteredOptions
gasparrobi
force-pushed
the
fix/combobox-highlight-on-search-term-change
branch
from
61a1e1e
to
3ba371f
Compare
1 task
timmaier
reviewed
Jul 23, 2024
| @@ -211,10 +211,10 @@ watch(stringifiedModelValue, async () => { | |||
| immediate: !props.searchTerm, | |||
| }) | |||
|
|
|||
| watch(() => filteredOptions.value.length, async (length) => { | |||
| watch(() => [filteredOptions.value.length, searchTerm.value.length], async ([length, searchTermLength], [oldLength, oldSearchTermLength]) => { | |||
There was a problem hiding this comment.
If searchTerm.value is null/undefined this causes a .length error and bugs out the Combobox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think current highlighting functionality is unintuitive.
When the user is removing characters (eg: by backspacing) the highlighted option should always be the first matching option from the dropdown list. It should provide the same behavior as typing, but backwards.
for reference please check shadcn/ui's combobox or headleassui's combobox
this PR is fixing that behavior.
before:
after the change:
