Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Editable): allow space inputs when submitMode is enter #1013

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

ricketyBridges
Copy link
Contributor

Context: #1008

Currently editable is very strict and submits on space input, even if submitMode is set to enter. This changes it to only enforce shift-space usage when submitMode is both.

@epr3 epr3 changed the title fix(editable): allow space inputs when submitMode is enter fix(Editable): allow space inputs when submitMode is enter Jun 20, 2024
Copy link
Collaborator

@epr3 epr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@epr3 epr3 merged commit 87cfcbb into radix-vue:main Jun 20, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants