-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixes the overflow when a toast is displayed on mobile #429
fix: fixes the overflow when a toast is displayed on mobile #429
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we should set as 0px
(based on this https://github.com/twbs/bootstrap/blob/9c1c3d4d048eeb8b685e5442c21489f101c4ad05/scss/mixins/_visually-hidden.scss)
maybe there's something we're missing on mobile.. causing it to renders differently |
Hey @zernonia , the element in question is actually the span tag that renders the text from the toast |
Icic.. could you screenshot what is the UI looks like currently with that |
thanks guys!!! I realized my stupid mistake lol... it should be |
Sure thing. And leave the display as inline-block correct? From what I remember about css, width and won't have an effect on items that are displayed inline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! I think leaving inline-block
should be fine 😁!
Thanks @BayBreezy !
On mobile, rendering the toast component would cause an overflow on the x axis.
After inspecting the DOM, I realised that adding a width of 0px and display of inline-block fixed the issue.