fix: remove duplicate keydown enter #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
2 tasks
|
@zernonia Thank you for reviewing my code. Actually, I've followed you from Vue.js Nation 2024 yesterday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is related to #638.
I saw
ToggleRootemitted an event twice,@clickand@keydown.enter. This madepressedwas mutated twice too.Then, I removed
@keydown.enter, an event was still emitted after pressingEnterbut only once from@click.@clickworks with pressingSpacetoo.Scope of work
I have removed
@keydown.enterfromToggleRoot.If you have any feedback or suggestion, please let me know.