feat(Pagination): ellipsis should separate at least 2 pages #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @andreww2012 .. Not sure what you are looking for.. have you tried changing |
|
Hey @zernonia! I don't think this is related to On the screenshot (taken directly from the radix-vue site), "..." is put between pages 1 and 3, but it can just be replaced with "2". Same happens on the right side, in the end of the list. This PR changes exactly that 🙂 Other UI libs handle this case, for example: |
zernonia
approved these changes
Feb 1, 2024
|
I was about to make necessary changes in tests this evening, but you beat me. Thank you for that & merging! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Rendering an ellipsis in the Pagination component when it only put instead of a single page item is not that useful I think:
This PR changes this behavior by requiring the difference between pages that ellipsis separate be at least 2.