fix(PinInput): remove trailing empty strings from modelValue
#793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zernonia
approved these changes
Mar 30, 2024
There was a problem hiding this comment.
I had the similar solution in mind when you mentioned the problem! Nicely done @DamianGlowala and LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, trailing empty strings make it more difficult to validate the input with libraries like FormKit with one particular scenario in mind, where all strings are empty and there is a
requiredrule applied.Instead of
['', '', ''](which therequiredrule would accept), this PR changes it to[], which this rule correctly reports as invalid.