Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make hover card tappable #803

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Conversation

remonke
Copy link
Contributor

@remonke remonke commented Apr 1, 2024

Let's just remove this.

In Radix Primitives for React this doesn't even do anything as the event there is some weird React abstraction.

@remonke
Copy link
Contributor Author

remonke commented Apr 1, 2024

#802

@ChrisGV04
Copy link
Contributor

Looks great!

I didn't see this PR and opened another one almost identical, but I already closed it. Sorry.

I also suggest replacing the end of docs with the real keyboard interactions: docs/content/components/hover-card.md

## Accessibility

The hover card is intended for sighted users only, the content will be inaccessible to keyboard users.

### Keyboard Interactions

<KeyboardTable :data="[
    {
      keys: ['Tab'],
      description: 'Opens/closes the hover card.',
    },
    {
      keys: ['Enter'],
      description: 'Opens the hover card link',
    }]" />

This comes from Radix UI.

@zernonia zernonia linked an issue Apr 2, 2024 that may be closed by this pull request
Copy link
Collaborator

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @remonke ! Happy with removing @touchstart.prevent, however I'll like to keep the utility function the same.

And let's add the docs regarding the Accessibility as suggested by @ChrisGV04 😁

packages/radix-vue/src/HoverCard/utils.ts Show resolved Hide resolved
Copy link
Collaborator

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @remonke . Reverted @pointerleave as it overwrote the GraceArea feature of HoverCard

@zernonia zernonia merged commit 340e150 into radix-vue:main Apr 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: HoverCardTrigger is untappable on mobile
3 participants