-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make hover card tappable #803
Conversation
Looks great! I didn't see this PR and opened another one almost identical, but I already closed it. Sorry. I also suggest replacing the end of docs with the real keyboard interactions: ## Accessibility
The hover card is intended for sighted users only, the content will be inaccessible to keyboard users.
### Keyboard Interactions
<KeyboardTable :data="[
{
keys: ['Tab'],
description: 'Opens/closes the hover card.',
},
{
keys: ['Enter'],
description: 'Opens the hover card link',
}]" /> This comes from Radix UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @remonke ! Happy with removing @touchstart.prevent
, however I'll like to keep the utility function the same.
And let's add the docs regarding the Accessibility as suggested by @ChrisGV04 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @remonke . Reverted @pointerleave
as it overwrote the GraceArea
feature of HoverCard
Let's just remove this.
In Radix Primitives for React this doesn't even do anything as the
event
there is some weird React abstraction.