Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs): tabs components accepts string or number values #832

Merged
merged 5 commits into from
Apr 7, 2024

Conversation

Chrtyaka
Copy link
Contributor

@Chrtyaka Chrtyaka commented Apr 7, 2024

Hi! 馃憢馃徎 Closes #820

Changed

  • TabsTrigger, TabsRoot, TabsContent components now accept string or number values
  • defaultValue in TabsRoot component now accept string or number values
  • utils function for generating contentId and triggerId now accept value as string or number

Types

  • create type StringOrNumber in shared/types.

Tests

  • update testing component template for using numbers and strings. All tests passed

Docs

  • gen docs

Copy link
Collaborator

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 馃殌 Thanks @Chrtyaka !

@zernonia zernonia merged commit 14b4fc7 into radix-vue:main Apr 7, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Make <TabsRoot>'s modelValue accept string | number
2 participants