Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Select): body lock property #874

Merged
merged 2 commits into from
Apr 27, 2024
Merged

Conversation

epr3
Copy link
Collaborator

@epr3 epr3 commented Apr 23, 2024

Hello,

This PR adds a bodyLock property to the SelectContent component behaving in the same way as the ComboboxContent component.

This PR should also fix #873.

Let me know if there's anything else that would need to be added.

Thanks!

@epr3 epr3 requested a review from zernonia April 23, 2024 13:46
@zernonia zernonia merged commit dccb5be into radix-vue:main Apr 27, 2024
2 of 3 checks passed
@zernonia
Copy link
Collaborator

Thanks for the quick PR @epr3 !

@MellKam
Copy link
Collaborator

MellKam commented Apr 27, 2024

It seems like I'm late, but I think it should be named modal instead of bodyLock to keep prop naming consistent. Wdyt? @epr3

@epr3
Copy link
Collaborator Author

epr3 commented Apr 28, 2024

Hello @MellKam,

I agree with keeping the prop names consistent, but from what I've gathered from the codebase:

  • modal is used on Root components, whereas bodyLock is used on Content components
  • modal is used to signal that the component disables/enables interaction outside itself, bodyLock only handles the scroll
  • Combobox, which is basically a Select, uses the bodyLock prop

@MellKam
Copy link
Collaborator

MellKam commented Apr 28, 2024

@epr3 Okey, it makes sense 👍🏻

@zernonia
Copy link
Collaborator

Thanks for asking abou this @MellKam ! Hope that the answer above clarifies the decision on the prop naming here 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants