Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(accordion): remove unused open prop from the CollapsibleContent instance #889

Merged

Conversation

dwightjack
Copy link
Contributor

In AccordionContent we are passing a open prop to the CollapsibleContent instance even if it does not support such prop.

On a related note: I noticed that the data-disabled attribute is applied even if the item or the root is not disabled. It might have something to do with the line:

|| (rootContext.isSingle.value && open.value && !rootContext.collapsible)

but I lack the context to understand if it's a bug or not.

@zernonia
Copy link
Collaborator

zernonia commented May 1, 2024

Thanks for another PR @dwightjack ! The data-disabled state would present when the AccordionItem is not closable.

In the case of type=single, collapsible=false and open=true, we will make it not closable. Thus it's not really a bug ya 😁

@zernonia zernonia merged commit af7257e into radix-vue:main May 1, 2024
2 checks passed
@dwightjack
Copy link
Contributor Author

Thanks for another PR @dwightjack ! The data-disabled state would present when the AccordionItem is not closable.

In the case of type=single, collapsible=false and open=true, we will make it not closable. Thus it's not really a bug ya 😁

@zernonia thanks for the clarification. It makes totally sense 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants