Fix(accordion): remove unused open prop from the CollapsibleContent instance #889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
AccordionContent
we are passing aopen
prop to theCollapsibleContent
instance even if it does not support such prop.On a related note: I noticed that the
data-disabled
attribute is applied even if the item or the root is not disabled. It might have something to do with the line:radix-vue/packages/radix-vue/src/Accordion/AccordionItem.vue
Line 68 in 3a4188c
but I lack the context to understand if it's a bug or not.