Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make null to showPlaceholder #912

Merged
merged 1 commit into from
May 13, 2024
Merged

fix: make null to showPlaceholder #912

merged 1 commit into from
May 13, 2024

Conversation

zernonia
Copy link
Collaborator

No description provided.

@zernonia zernonia linked an issue May 13, 2024 that may be closed by this pull request
[Feature]: Treat null as an empty value for Select #880
Closed
2 tasks
@zernonia zernonia merged commit ac3a6da into main May 13, 2024
2 checks passed
zernonia added a commit that referenced this pull request May 13, 2024
@zernonia
feat: expose more slotProps (#915)
f0bd36b 
* fix(Progress): indeterminate state is wrong  when value is 0 (#911)

* fix(Select): make `null` to showPlaceholder (#912)

* feat: expost slotProps to all useVModel state

* docs: codegen

* chore: make sure boolean state is correct
@kilobyte2007
Copy link

kilobyte2007 commented May 14, 2024 •
edited

Shouldn't we then also add null as the type to themodelValue prop type here:

radix-vue/packages/radix-vue/src/Select/SelectRoot.vue

Line 14 in 64d7eb2

modelValue?: string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Treat null as an empty value for Select
2 participants
@zernonia @kilobyte2007