New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement aschild to relevant components #96
Conversation
alot of things are breaking @zernonia , it cant handle ref as usual I think Also this wasnt by adding the asChild attribute |
thanks @khairulhaaziq . I suspect some event/event listener wasn't passed in correctly. |
in this pr ive implemented the aschild to almost everything accept the components that hasnt been built, if one you fixed the problems, you can review this |
@zernonia this might be useful aswell https://www.radix-ui.com/docs/primitives/utilities/slot |
#93
#1 Accordion (Skip)
#2 Alert Dialog
#3 Aspect Ratio
#4 Avatar
#5 Checkbox
#6 Collapsible
#7 Context Menu (Skip)
#8 DIalog
#9 Dropdown Menu
#10 Form (Skip)
#11 Hover Card
#12 Label
#13 Menubar (Skip)
#14 Navigation Menu (Skip)
#15 Popover
#16 Progress
#17 Radio Group
#18 Scroll Area (Skip)
#19 Select (Skip)
TBD
#20 Separator
#21 Slider
#22 Switch
#23 Tabs
#24 Toast (Skip)
#25 Toggle
#26 Toggle Group
#27 Toolbar
#28 Tooltip