Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement aschild to relevant components #96

Merged
merged 9 commits into from Jun 29, 2023

Conversation

khairulhaaziq
Copy link
Member

@khairulhaaziq khairulhaaziq commented Jun 28, 2023

#93

#1 Accordion (Skip)

  • Root
  • Item
  • Header
  • Content

#2 Alert Dialog

  • Trigger
  • Overlay
  • Content
  • Cancel
  • Title
  • Description

#3 Aspect Ratio

  • Root

#4 Avatar

  • Root
  • Image
  • Fallback

#5 Checkbox

  • Root
  • Indicator

#6 Collapsible

  • Root
  • Trigger
  • Content

#7 Context Menu (Skip)

  • Trigger
  • Content
  • Arrow
  • Item
  • Group
  • Label
  • CheckboxItem
  • RadioGroup
  • RadioItem
  • ItemIndicator
  • Separator
  • Sub
  • SubTrigger
  • SubContent

#8 DIalog

  • Trigger
  • Overlay
  • Content
  • Close
  • Title
  • Description

#9 Dropdown Menu

  • Trigger
  • Content
  • Arrow
  • Item
  • Group
  • Label
  • CheckboxItem
  • RadioGroup
  • RadioItem
  • ItemIndicator
  • Separator
  • Sub
  • SubTrigger
  • SubContent

#10 Form (Skip)

  • Root
  • Field
  • Label
  • Control
  • Message
  • Submit

#11 Hover Card

  • Trigger
  • Content
  • Arrow

#12 Label

  • Root

#13 Menubar (Skip)

  • Root
  • Menu
  • Trigger
  • Content
  • Arrow
  • Item
  • Group
  • Label
  • CheckboxItem
  • RadioGroup
  • RadioItem
  • ItemIndicator
  • Separator
  • Sub
  • SubTrigger
  • SubContent

#14 Navigation Menu (Skip)

  • List
  • Item
  • Trigger
  • Content
  • Link
  • Indicator
  • Viewport

#15 Popover

  • Trigger
  • Anchor
  • Content
  • Arrow
  • Close

#16 Progress

  • Root
  • Indicator

#17 Radio Group

  • Root
  • Item
  • Indicator

#18 Scroll Area (Skip)

  • Root
  • Viewport
  • Scrollbar
  • Thumb
  • Corner

#19 Select (Skip)

TBD

#20 Separator

  • Root

#21 Slider

  • Root
  • Track
  • Range
  • Thumb

#22 Switch

  • Root
  • Thumb

#23 Tabs

  • Root
  • List
  • Trigger
  • Content

#24 Toast (Skip)

  • Viewport
  • Root
  • Title
  • Description
  • Action
  • Close

#25 Toggle

  • Root

#26 Toggle Group

  • Root
  • Item

#27 Toolbar

  • Root
  • Button
  • Link
  • ToggleGroup
  • ToggleItem
  • Separator

#28 Tooltip

  • Trigger
  • Content
  • Arrow

@khairulhaaziq
Copy link
Member Author

khairulhaaziq commented Jun 28, 2023

alot of things are breaking @zernonia , it cant handle ref as usual I think
Screenshot 2023-06-28 at 9 39 52 PM
Screenshot 2023-06-28 at 9 39 45 PM

Also this wasnt by adding the asChild attribute

@khairulhaaziq khairulhaaziq linked an issue Jun 28, 2023 that may be closed by this pull request
2 tasks
@khairulhaaziq khairulhaaziq self-assigned this Jun 28, 2023
@zernonia
Copy link
Collaborator

zernonia commented Jun 28, 2023

thanks @khairulhaaziq . I suspect some event/event listener wasn't passed in correctly.
May I know which component you are wrapping the Primitive, and causing the above error ya?

@khairulhaaziq
Copy link
Member Author

thanks @khairulhaaziq . I suspect some event/event listener wasn't passed in correctly. May I know which component you are wrapping the Primitive, and causing the above error ya?

in this pr ive implemented the aschild to almost everything accept the components that hasnt been built, if one you fixed the problems, you can review this

@khairulhaaziq
Copy link
Member Author

thanks @khairulhaaziq . I suspect some event/event listener wasn't passed in correctly. May I know which component you are wrapping the Primitive, and causing the above error ya?

@zernonia this might be useful aswell https://www.radix-ui.com/docs/primitives/utilities/slot

@zernonia zernonia marked this pull request as ready for review June 29, 2023 08:23
@zernonia zernonia merged commit 5c68442 into main Jun 29, 2023
@khairulhaaziq khairulhaaziq deleted the feat-implement-aschild branch June 29, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: implement asChild to every component needed
2 participants