Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(app): add Astro guide #118

Merged
merged 3 commits into from
Oct 22, 2023
Merged

Conversation

selemondev
Copy link
Contributor

@selemondev selemondev commented Oct 14, 2023

This pull request is intended to add a guide on how to install, configure and use Shadcn-Vue with Astro.

Closes #90

@selemondev selemondev changed the title docs(app): add astro guide docs(app): add Astro guide Oct 14, 2023
@sadeghbarati
Copy link
Collaborator

sadeghbarati commented Oct 15, 2023

//cc @Dunqing 🙏

  • pnpm dlx astro add tailwind
  • pnpm dlx shadcn-vue@latest init

image


Prompt texts are also different

image
image

@selemondev
Copy link
Contributor Author

@sadeghbarati Does this pull request solve the issue or does it need more commits?

@sadeghbarati
Copy link
Collaborator

sadeghbarati commented Oct 15, 2023

Your PR is good but shadcn-vue CLI need some change when the framework is Astro

let's merge when everything is ok 🙏

@selemondev
Copy link
Contributor Author

Your PR is good but shadcn-vue CLI need some change when the framework is Astro

let's merge when everything is ok 🙏

What change, if I may ask?

@sadeghbarati
Copy link
Collaborator

sadeghbarati commented Oct 15, 2023

I explained with the images above 👆

  • shadcn-vue CLI created tailwind.config.js
  • astro CLI created tailwind.config.mjs

@selemondev
Copy link
Contributor Author

I explained with the images above 👆

  • shadcn-vue CLI created tailwind.config.js
  • astro CLI created tailwind.config.mjs

Will this be opened as an issue?

@Dunqing
Copy link
Collaborator

Dunqing commented Oct 15, 2023

I think both tailwind.config.js and tailwind.config.mjs should be supported in shadcn-vue. I will support it soon.

@zernonia
Copy link
Contributor

Nice suggestion guys! As different modules add tailwind differently, it's good that we cover most of the use case for tailwind.config.{js,cjs,mjs}. I believe #120 would work nicely!

@zernonia
Copy link
Contributor

Thanks guys! I've merge #120 and released 0.6.0. @selemondev could you test it on astro and check if everything is working as expected? Then we can merge this 😁

@selemondev
Copy link
Contributor Author

selemondev commented Oct 21, 2023

Thanks guys! I've merge #120 and released 0.6.0. @selemondev could you test it on astro and check if everything is working as expected? Then we can merge this 😁

I have tested it out but after the installation and adding of the Shadcn components, I had to install TypeScript as a dev dependency to get it working and resolve the error Cannot find module 'typescript'. It is the same case as Nuxt 3. Can I go ahead and add that in the documentation as well (Installing TypeScript as a dev dependency)?

@zernonia
Copy link
Contributor

Yes @selemondev . Let's add that step!

@selemondev
Copy link
Contributor Author

Yes @selemondev . Let's add that step!

Done 🥳.

@zernonia zernonia merged commit 537416f into radix-vue:dev Oct 22, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Is all this compatible with Astro + Vue?
4 participants