Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vue-tsc #182

Merged
merged 8 commits into from Nov 20, 2023
Merged

add vue-tsc #182

merged 8 commits into from Nov 20, 2023

Conversation

olemarius
Copy link
Contributor

@olemarius olemarius commented Nov 19, 2023

@olemarius olemarius changed the title fix: use DatePickerModel from v-calendar on modelValue add vue-tsc Nov 19, 2023
@sadeghbarati
Copy link
Collaborator

sadeghbarati commented Nov 20, 2023

import type { DatePickerModel } from 'v-calendar/dist/types/src/use/datePicker'

This will work only in "moduleResolution": "Node" the new Bundler mode will throw errors

Cannot find module 'v-calendar/dist/types/src/use/datePicker' or its corresponding type declarations.

Can you extract the type from v-calendar and put the type inside the Calendar.vue?


Looks like the main shadcn-ui is going to add the new Calendar implementation with @internationalized/date we can inspire from them once it's ready

@olemarius
Copy link
Contributor Author

@sadeghbarati ✅ done

@sadeghbarati sadeghbarati merged commit c242a79 into radix-vue:dev Nov 20, 2023
1 check failed
@sadeghbarati
Copy link
Collaborator

86nvki

@olemarius olemarius deleted the vue-tsc branch November 20, 2023 14:43
sadeghbarati added a commit to sadeghbarati/shadcn-vue that referenced this pull request Nov 26, 2023
feat: update

useLocalStorage instead of useSessionStorage

add vue-tsc typecheck before build registry (radix-vue#182)

* chore: add vue-tsc script

* fix: remove non existent props from ModelSelector

* fix: add basic typing for files

* fix: fix Artwork object in demo

* fix: use DatePickerModel from v-calendar on modelValue

Fixes vue-tsc validation errors

* chore: add `@vue/tsconfig`

* refactor: extracted types from v-calendar

---------

Co-authored-by: Sadegh Barati <sadeghbaratiwork@gmail.com>

chore: update deps

chore: release v0.8.3

feat(cli): add collapsible animations by default (radix-vue#186)

* feat(cli): add collapsible animations by default

* docs: add collapsible animation instructions

docs: fix demo after refactoring

fix: checkbox icon off-center fix (radix-vue#184)

* fix: checkbox icon off-center fix

* fix: checkbox icon off-center update fix

* fix: revert box-content

feat: update
sadeghbarati added a commit to sadeghbarati/shadcn-vue that referenced this pull request Nov 26, 2023
* chore: add vue-tsc script

* fix: remove non existent props from ModelSelector

* fix: add basic typing for files

* fix: fix Artwork object in demo

* fix: use DatePickerModel from v-calendar on modelValue

Fixes vue-tsc validation errors

* chore: add `@vue/tsconfig`

* refactor: extracted types from v-calendar

---------

Co-authored-by: Sadegh Barati <sadeghbaratiwork@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants