Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make NumberField more flexible (#613) #623

Merged
merged 3 commits into from
Jun 23, 2024
Merged

Conversation

hsellik
Copy link
Contributor

@hsellik hsellik commented Jun 19, 2024

πŸ”— Linked issue

#613

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Change the NumberField, so it could be used in different configurations without extra effort from the developer. Resolves #613

πŸ“Έ Screenshots (if appropriate)

Before:
image
image

After:
image
image

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Change the NumberField, so it could be used
in different configuration without extra
effort from the developer.
@sadeghbarati
Copy link
Collaborator

@hsellik Thanks Man πŸ™Œ

Can you run pnpm build:registry in apps/www

@hsellik
Copy link
Contributor Author

hsellik commented Jun 19, 2024

Oh, missed that one, pushed it now. The pnpm build:registry wants to remove empty lines at the end of the files for some reason, don't know if it's just my setup.

@sadeghbarati
Copy link
Collaborator

Will checkout to your branch tomorrow to push some changes if you don't mind πŸ™Œ

Cause using p-2.5 is not good imo

@sadeghbarati
Copy link
Collaborator

You were using the ring and focus stuff on div element in NumberFieldContent.vue which is not the best practice

The idea of data-slot is from tailwindui Catalyst template

@sadeghbarati sadeghbarati merged commit eeca60d into radix-vue:dev Jun 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: NumberField without Increment and Decrement
2 participants