fix: make NumberField more flexible (#613) #623
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#613
β Type of change
π Description
Change the NumberField, so it could be used in different configurations without extra effort from the developer. Resolves #613
πΈ Screenshots (if appropriate)
Before:
![image](https://private-user-images.githubusercontent.com/16798824/341148232-06a06e42-6989-4e44-acd5-536de3035c50.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk1Mzc0MzEsIm5iZiI6MTcxOTUzNzEzMSwicGF0aCI6Ii8xNjc5ODgyNC8zNDExNDgyMzItMDZhMDZlNDItNjk4OS00ZTQ0LWFjZDUtNTM2ZGUzMDM1YzUwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI4VDAxMTIxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTIxZjVmODU4ZGJlZWMzMWVmMzY4YThhODBjMGYzNTc1MmJmMzYyYjI0YjgwNzhlOGU3MmFjZjY2N2QyZjgzZmUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Q50nDa421m67mTqawpNrBOdaIcEk5OIEFAn3MXLts4w)
![image](https://private-user-images.githubusercontent.com/16798824/341148384-229db43a-426b-404e-bd19-0124eff1ab49.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk1Mzc0MzEsIm5iZiI6MTcxOTUzNzEzMSwicGF0aCI6Ii8xNjc5ODgyNC8zNDExNDgzODQtMjI5ZGI0M2EtNDI2Yi00MDRlLWJkMTktMDEyNGVmZjFhYjQ5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI4VDAxMTIxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkzMWM5MmIyOTZmNzgzYjkyNzgwODJmNzMwM2Q1YmNkM2Y2MjQ4MmY5MjJkOWYzYWM2ZmJmNDEzMmNlYmUzNzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Ecn-cN_rqXlFw7Wirg52JKIcRB-JMK544vgaNCqaLNY)
After:
![image](https://private-user-images.githubusercontent.com/16798824/341147653-9a40c609-ad49-4fae-a917-3c2b6d289090.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk1Mzc0MzEsIm5iZiI6MTcxOTUzNzEzMSwicGF0aCI6Ii8xNjc5ODgyNC8zNDExNDc2NTMtOWE0MGM2MDktYWQ0OS00ZmFlLWE5MTctM2MyYjZkMjg5MDkwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI4VDAxMTIxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBjODdiYzlkMDg2YzQ3Njc2NjJjNGIyZTYyY2E4YTg2NTBlYjEzNWEyYjk0OWVjMjM1YTZhYTM1OTI3NzIxNDkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.nd4qt6AHowJCz7ZMoWlwIgzvFkD4pHAaXgtR1Ku6qAE)
![image](https://private-user-images.githubusercontent.com/16798824/341147829-ac09dd94-9b56-4377-b44b-2b0b97187d56.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk1Mzc0MzEsIm5iZiI6MTcxOTUzNzEzMSwicGF0aCI6Ii8xNjc5ODgyNC8zNDExNDc4MjktYWMwOWRkOTQtOWI1Ni00Mzc3LWI0NGItMmIwYjk3MTg3ZDU2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI4VDAxMTIxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTczYjM2MjkxNmZlNGVjNzQ3ZTJmM2Q5MmZmMGUwYTI5MGFhZjRjNTY5ZjBlZmRhYmY1ZmQ4YWY4ZDdjNDc1OTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.yEHXrTY0MnHRSsUUF03RSnWuoeKKbj_2rXG3kHynon8)
π Checklist