[ABW-3213] Address Details #1100
Conversation
matiasbzurovski
added
the
DO NOT MERGE
| @@ -31,6 +31,21 @@ extension Gradient { | |||
| ] | |||
| } | |||
|
|
|||
| extension LinearGradient.App { | |||
| public var brand1: LinearGradient { | |||
There was a problem hiding this comment.
Ended up not being used on these designs but decided to keep it as we will probably need it somewhere else (it is part of the design system.
RadixWallet/Core/FeaturePrelude/AddressView/AddressDetails+View.swift
Outdated
Show resolved
Hide resolved
RadixWallet/Core/FeaturePrelude/AddressView/AddressDetails.swift
Outdated
Show resolved
Hide resolved
|
@matiasbzurovski Note: This is to be merged for the next 1.6.0 release if Android manages to implement it, otherwise it will go in 1.7.0 release. |
# Conflicts: # RadixWallet.xcodeproj/project.pbxproj
# Conflicts: # RadixWallet.xcodeproj/project.pbxproj
matiasbzurovski
removed
the
DO NOT MERGE
RadixWallet/Core/FeaturePrelude/AddressView/AddressDetails+View.swift
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| private extension AddressDetails.ViewState { | ||
| static func colorised(address: LedgerIdentifiable.Address) -> AttributedString { |
There was a problem hiding this comment.
I think this should be either a local private function, or, if you might want to use it somewhere else, a var on LedgerIdentifiable.Address or something.
There was a problem hiding this comment.
The idea was to computate it only once
There was a problem hiding this comment.
The ViewState is actually re-computed every time anything changes, as is the entire SwiftUI View, so I don't think it makes any difference.
But either way, my idea was just to change the ergonomics to something like this:
let addressString = address.colorizedString
It might be that Observable is smart enough to only recompute it when the underlying address changes if you do it like that. When it's in the ViewState, any change to any property on the ViewState would recompute everything.
Seems like it could be useful more generally, btw.
RadixWallet/Core/FeaturePrelude/AddressView/AddressDetails.swift
Outdated
Show resolved
Hide resolved
RadixWallet/Core/FeaturePrelude/AddressView/AddressDetails.swift
Outdated
Show resolved
Hide resolved
| // MARK: - Helpers | ||
|
|
||
| private extension OnLedgerEntity.Resource { | ||
| var resourceTitle: String? { |
There was a problem hiding this comment.
We used to have something with a very similar name, which returned metadata.symbol ?? metadata.name, but I can't find it right now. If it still exists somewhere it might be a bit confusing.
There was a problem hiding this comment.
Probably this title defined on OnLedgerEntity.Metadata.
The one I defined is private anyway, and is an improved version of it. smartResourceTitle?
There was a problem hiding this comment.
I wouldn't say it's improved, it's different, and only makes sense here
There was a problem hiding this comment.
So I would just make it a private computed property in the View
| .foregroundColor(.app.gray1) | ||
| Text(address) | ||
| private func qrCode(qrImage: Loadable<CGImage>) -> some SwiftUI.View { | ||
| ZStack { |
There was a problem hiding this comment.
What does the ZStack do here? It looks like each branch only returns a single element, so it would seem that it would be enough to put @ViewBuilder on the function
| // MARK: - Enlarged view | ||
| private extension AddressDetails.View { | ||
| var enlargedView: some SwiftUI.View { | ||
| Group { |
There was a problem hiding this comment.
What is the purpose of the Group?
| private var enlargedViewBackrgound: some View { | ||
| Color.black.opacity(0.2) | ||
| .frame(width: UIScreen.main.bounds.width * 2, height: UIScreen.main.bounds.height * 2) | ||
| .contentShape(Rectangle()) |
There was a problem hiding this comment.
contentShape controls the tappable area, when you have a part of the view that has alpha=0, but all of this view is black, so isn't it already tappable?
| private func loadTitle(address: LedgerIdentifiable.Address) async throws -> String? { | ||
| switch address { | ||
| case let .account(address, _): | ||
| let account = try await accountsClient.getAccountByAddress(address) |
There was a problem hiding this comment.
I suppose it's a matter of taste but it looks like all these branches could be written as one-liners, without a return.
try await accountsClient.getAccountByAddress(address).displayName.rawValue
| await send(.internal(.loadedTitle(TaskResult { | ||
| try await loadTitle(address: address) | ||
| }))) | ||
| } |
| @@ -1,18 +1,21 @@ | |||
| // MARK: - AddressDetails | |||
| public struct AddressDetails: Sendable, FeatureReducer { | |||
There was a problem hiding this comment.
You can add @Reducer to this. Then you need to also put public typealias Action = FeatureAction<Self> explicitly, otherwise the compiler gets confused.
|
Now the dismiss doesn't actually work for me in your PR. But putting |
Jira ticket: ABW-3213
Jira ticket: ABW-3256
Description
This PR adds a sheet presented every time the user taps on an
AddressViewwith aLedgerIdentifiable.Addressassociated.Video
demo.mov