[ABW-3213] Address Details #1100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasbzurovski
added
the
DO NOT MERGE
matiasbzurovski
commented
Apr 26, 2024
| @@ -31,6 +31,21 @@ extension Gradient { | |||
| ] | |||
| } | |||
|
|
|||
| extension LinearGradient.App { | |||
| public var brand1: LinearGradient { | |||
There was a problem hiding this comment.
Ended up not being used on these designs but decided to keep it as we will probably need it somewhere else (it is part of the design system.
matiasbzurovski
commented
Apr 26, 2024
RadixWallet/Core/FeaturePrelude/AddressView/AddressDetails+View.swift
Outdated
Show resolved
Hide resolved
matiasbzurovski
commented
Apr 26, 2024
| public struct AddressDetails: Sendable, FeatureReducer { | ||
| public struct State: Sendable, Hashable { | ||
| let address: LedgerIdentifiable.Address | ||
| let closeAction: (() -> Void)? |
There was a problem hiding this comment.
It really bothers me that we need to send a non-sendable closure to this state.. But it is the only way I was able to handle dismissal when the view is presented from AddressView (which is a plain SwiftUI vanilla view). Open to better suggestions.
|
@matiasbzurovski Note: This is to be merged for the next 1.6.0 release if Android manages to implement it, otherwise it will go in 1.7.0 release. |
# Conflicts: # RadixWallet.xcodeproj/project.pbxproj
# Conflicts: # RadixWallet.xcodeproj/project.pbxproj
matiasbzurovski
removed
the
DO NOT MERGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-3213
Jira ticket: ABW-3256
Description
This PR adds a sheet presented every time the user taps on an
AddressViewwith aLedgerIdentifiable.Addressassociated.Video
demo.mov