Skip to content
This repository has been archived by the owner on Feb 19, 2024. It is now read-only.

Add a separate testnets forks module #687

Merged
merged 1 commit into from May 11, 2022

Conversation

LukasGasior1
Copy link
Contributor

No description provided.

Copy link
Contributor

@siy siy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented May 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

49.6% 49.6% Coverage
0.0% 0.0% Duplication

@LukasGasior1 LukasGasior1 merged commit 39abb79 into main May 11, 2022
@LukasGasior1 LukasGasior1 deleted the feature/separate-testnet-fork-configs branch May 11, 2022 14:26

private static final Map<Integer, AbstractModule> FORKS_MODULE_BY_NETWORK_ID =
Map.of(
Network.MAINNET.getId(), new MainnetForksModule(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use Network.MAINNET as the key instead of Id?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could but then I'd need an extra Network.ofId call when accessing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants