Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

missing param for hw sign #149

Merged
merged 2 commits into from
Jun 28, 2021
Merged

missing param for hw sign #149

merged 2 commits into from
Jun 28, 2021

Conversation

AbstractFruitFactory
Copy link
Contributor

No description provided.

Sajjon
Sajjon approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@Sajjon Sajjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Sajjon
Copy link
Contributor

Sajjon commented Jun 28, 2021

Note regarding the changes of readUint8() to readUint8(0) is that this fixes this bug relating to how buffers in Electron behave.

@AbstractFruitFactory AbstractFruitFactory merged commit 645d59c into main Jun 28, 2021
@AbstractFruitFactory AbstractFruitFactory deleted the fixes-for-hw-sign branch June 28, 2021 10:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Sajjon Sajjon Sajjon approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@AbstractFruitFactory @Sajjon