Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol updates in simulator #1681

Merged

Conversation

0xOmarA
Copy link
Member

@0xOmarA 0xOmarA commented Jan 16, 2024

Summary

This PR includes some minor clean ups and performs the protocol update state changes in the simulator environment.

@0xOmarA 0xOmarA force-pushed the feature/protocol-updates-in-simulator branch from 0ccb7f2 to c1cd852 Compare January 16, 2024 18:08
Copy link

Benchmark for e46e525

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 64.8±0.47ms 64.3±0.38ms -0.77%
costing::decode_sbor 13.0±0.03µs 13.2±0.04µs +1.54%
costing::decode_sbor_bytes 35.5±0.02µs 36.3±0.13µs +2.25%
costing::deserialize_wasm 1242.1±5.55µs 1239.8±3.40µs -0.19%
costing::instantiate_flash_loan 3.6±0.06ms 3.9±0.42ms +8.33%
costing::instantiate_radiswap 5.1±0.07ms 5.1±0.06ms 0.00%
costing::spin_loop 21.6±0.03ms 21.6±0.02ms 0.00%
costing::validate_sbor_payload 24.8±0.02µs 24.5±0.27µs -1.21%
costing::validate_sbor_payload_bytes 338.1±0.44ns 337.2±0.23ns -0.27%
costing::validate_secp256k1 80.3±0.12µs 80.3±0.38µs 0.00%
costing::validate_wasm 36.1±0.09ms 34.4±0.04ms -4.71%
decimal::add/0 7.2±0.00ns 7.2±0.00ns 0.00%
decimal::add/rust-native 9.2±0.02ns 9.2±0.07ns 0.00%
decimal::add/wasmer 136.3±0.12ns 132.1±0.22ns -3.08%
decimal::add/wasmer-call-native 517.7±0.15ns 549.9±0.45ns +6.22%
decimal::add/wasmi 446.0±0.27ns 460.3±5.49ns +3.21%
decimal::add/wasmi-call-native 3.4±0.02µs 3.3±0.02µs -2.94%
decimal::div/0 164.6±0.11ns 164.6±0.06ns 0.00%
decimal::from_string/0 153.3±0.16ns 153.5±0.07ns +0.13%
decimal::mul/0 128.2±0.08ns 127.8±0.08ns -0.31%
decimal::mul/rust-native 131.6±0.10ns 131.6±0.06ns 0.00%
decimal::mul/wasmer 1717.4±0.70ns 1717.9±0.46ns +0.03%
decimal::mul/wasmer-call-native 652.6±0.20ns 653.9±0.16ns +0.20%
decimal::mul/wasmi 26.9±0.03µs 26.7±0.04µs -0.74%
decimal::mul/wasmi-call-native 3.5±0.05µs 3.4±0.01µs -2.86%
decimal::pow/0 620.9±0.20ns 621.9±0.33ns +0.16%
decimal::pow/rust-native 607.9±0.36ns 605.8±0.53ns -0.35%
decimal::pow/wasmer 7.5±0.00µs 7.5±0.00µs 0.00%
decimal::pow/wasmer-call-native 1077.3±0.43ns 1078.5±0.37ns +0.11%
decimal::pow/wasmi 128.1±0.13µs 126.8±0.15µs -1.01%
decimal::pow/wasmi-call-native 3.4±0.01µs 3.4±0.01µs 0.00%
decimal::root/0 9.1±0.01µs 9.3±0.00µs +2.20%
decimal::sub/0 7.2±0.00ns 7.2±0.00ns 0.00%
decimal::to_string/0 487.5±0.22ns 487.8±0.19ns +0.06%
precise_decimal::add/0 8.0±0.01ns 8.0±0.00ns 0.00%
precise_decimal::add/rust-native 10.4±0.02ns 10.4±0.02ns 0.00%
precise_decimal::add/wasmer 142.8±0.04ns 139.0±0.05ns -2.66%
precise_decimal::add/wasmer-call-native 534.1±0.20ns 538.6±0.09ns +0.84%
precise_decimal::add/wasmi 535.1±0.16ns 527.1±0.20ns -1.50%
precise_decimal::add/wasmi-call-native 3.6±0.02µs 3.7±0.02µs +2.78%
precise_decimal::div/0 264.2±0.11ns 261.8±0.09ns -0.91%
precise_decimal::from_string/0 195.0±0.08ns 195.0±0.16ns 0.00%
precise_decimal::mul/0 284.2±0.30ns 281.4±0.09ns -0.99%
precise_decimal::mul/rust-native 261.1±0.09ns 260.7±0.06ns -0.15%
precise_decimal::mul/wasmer 4.0±0.00µs 4.1±0.00µs +2.50%
precise_decimal::mul/wasmer-call-native 816.3±0.38ns 821.0±0.96ns +0.58%
precise_decimal::mul/wasmi 74.4±0.06µs 74.3±0.02µs -0.13%
precise_decimal::mul/wasmi-call-native 3.9±0.01µs 4.0±0.01µs +2.56%
precise_decimal::pow/0 1572.2±0.28ns 1574.0±1.14ns +0.11%
precise_decimal::pow/rust-native 1275.2±0.45ns 1277.9±1.50ns +0.21%
precise_decimal::pow/wasmer 19.0±0.01µs 19.0±0.01µs 0.00%
precise_decimal::pow/wasmer-call-native 2.0±0.00µs 2.0±0.00µs 0.00%
precise_decimal::pow/wasmi 359.0±0.11µs 358.2±0.13µs -0.22%
precise_decimal::pow/wasmi-call-native 7.5±0.03µs 7.4±0.03µs -1.33%
precise_decimal::root/0 60.9±0.01µs 61.6±0.02µs +1.15%
precise_decimal::sub/0 8.3±0.00ns 8.3±0.01ns 0.00%
precise_decimal::to_string/0 746.7±0.40ns 742.9±0.17ns -0.51%
schema::validate_payload 331.9±0.24µs 370.5±0.20µs +11.63%
transaction::radiswap 5.2±0.04ms 5.2±0.04ms 0.00%
transaction::transfer 1683.1±2.69µs 1671.5±3.72µs -0.69%
transaction_processing::prepare 2.4±0.00ms 2.4±0.00ms 0.00%
transaction_processing::prepare_and_decompile 6.1±0.01ms 6.2±0.01ms +1.64%
transaction_processing::prepare_and_decompile_and_recompile 23.7±0.32ms 23.0±0.34ms -2.95%
transaction_validation::validate_manifest 43.8±0.24µs 43.8±0.10µs 0.00%
transaction_validation::verify_bls_2KB 1000.2±1.39µs 1000.0±1.09µs -0.02%
transaction_validation::verify_bls_32B 999.1±3.79µs 1001.8±11.16µs +0.27%
transaction_validation::verify_ecdsa 78.0±0.07µs 78.0±0.06µs 0.00%
transaction_validation::verify_ed25519 51.4±0.12µs 51.4±0.04µs 0.00%

@0xOmarA 0xOmarA merged commit cffcce6 into feature/pool-improvements Jan 16, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants