Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/compare current time input naming #1682

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

dhedey
Copy link
Contributor

@dhedey dhedey commented Jan 16, 2024

Summary

As per comments in this PR here: https://github.com/radixdlt/radixdlt-scrypto/pull/1672/files#r1449180597

Fixes:

  • Typo in ConsensusManagerCompareCurrentTimeInputX type names
  • Improves stake_reconciliation test to make it easier to debug

Copy link

Benchmark for bb3fc0d

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 66.3±0.14ms 66.7±0.15ms +0.60%
costing::decode_sbor 13.1±0.02µs 13.2±0.01µs +0.76%
costing::decode_sbor_bytes 35.6±0.26µs 39.1±0.11µs +9.83%
costing::deserialize_wasm 1247.7±2.11µs 1250.2±2.50µs +0.20%
costing::instantiate_flash_loan 4.1±0.57ms 4.6±0.83ms +12.20%
costing::instantiate_radiswap 5.5±0.06ms 5.5±0.05ms 0.00%
costing::spin_loop 22.0±0.08ms 22.0±0.10ms 0.00%
costing::validate_sbor_payload 26.2±0.03µs 26.0±0.02µs -0.76%
costing::validate_sbor_payload_bytes 354.5±1.91ns 354.1±0.24ns -0.11%
costing::validate_secp256k1 80.6±0.07µs 80.6±0.13µs 0.00%
costing::validate_wasm 35.1±0.03ms 35.0±0.03ms -0.28%
decimal::add/0 7.2±0.00ns 7.2±0.00ns 0.00%
decimal::add/rust-native 9.2±0.08ns 9.2±0.03ns 0.00%
decimal::add/wasmer 133.3±0.10ns 134.4±0.08ns +0.83%
decimal::add/wasmer-call-native 519.7±0.14ns 521.9±0.09ns +0.42%
decimal::add/wasmi 446.7±0.21ns 438.1±0.12ns -1.93%
decimal::add/wasmi-call-native 3.3±0.01µs 3.3±0.01µs 0.00%
decimal::div/0 165.9±0.18ns 165.9±0.17ns 0.00%
decimal::from_string/0 153.8±0.19ns 156.3±0.14ns +1.63%
decimal::mul/0 128.9±0.13ns 128.8±0.04ns -0.08%
decimal::mul/rust-native 131.9±0.07ns 131.5±0.06ns -0.30%
decimal::mul/wasmer 1734.5±0.52ns 1720.6±0.74ns -0.80%
decimal::mul/wasmer-call-native 683.1±0.28ns 657.3±0.27ns -3.78%
decimal::mul/wasmi 26.6±0.03µs 26.7±0.02µs +0.38%
decimal::mul/wasmi-call-native 3.4±0.01µs 3.5±0.03µs +2.94%
decimal::pow/0 622.3±0.29ns 622.4±0.58ns +0.02%
decimal::pow/rust-native 606.9±0.37ns 608.6±0.30ns +0.28%
decimal::pow/wasmer 7.5±0.00µs 7.5±0.01µs 0.00%
decimal::pow/wasmer-call-native 1082.7±1.41ns 1080.5±0.35ns -0.20%
decimal::pow/wasmi 126.5±0.14µs 128.4±0.10µs +1.50%
decimal::pow/wasmi-call-native 3.4±0.01µs 3.4±0.01µs 0.00%
decimal::root/0 9.2±0.00µs 9.2±0.01µs 0.00%
decimal::sub/0 7.2±0.01ns 7.2±0.00ns 0.00%
decimal::to_string/0 489.2±0.21ns 488.8±0.23ns -0.08%
precise_decimal::add/0 8.1±0.01ns 8.1±0.00ns 0.00%
precise_decimal::add/rust-native 10.4±0.04ns 10.4±0.01ns 0.00%
precise_decimal::add/wasmer 141.0±0.08ns 141.7±0.90ns +0.50%
precise_decimal::add/wasmer-call-native 537.8±0.21ns 537.9±0.67ns +0.02%
precise_decimal::add/wasmi 533.1±0.12ns 533.4±0.15ns +0.06%
precise_decimal::add/wasmi-call-native 3.7±0.01µs 3.7±0.03µs 0.00%
precise_decimal::div/0 265.0±0.32ns 264.8±0.33ns -0.08%
precise_decimal::from_string/0 195.7±0.14ns 195.7±0.13ns 0.00%
precise_decimal::mul/0 287.6±5.01ns 284.6±0.09ns -1.04%
precise_decimal::mul/rust-native 287.2±0.10ns 264.4±0.07ns -7.94%
precise_decimal::mul/wasmer 4.0±0.00µs 4.1±0.00µs +2.50%
precise_decimal::mul/wasmer-call-native 820.5±0.26ns 829.7±0.38ns +1.12%
precise_decimal::mul/wasmi 73.9±0.06µs 74.6±0.07µs +0.95%
precise_decimal::mul/wasmi-call-native 3.9±0.03µs 3.9±0.02µs 0.00%
precise_decimal::pow/0 1589.6±0.43ns 1576.3±3.32ns -0.84%
precise_decimal::pow/rust-native 1275.9±0.26ns 1275.9±0.35ns 0.00%
precise_decimal::pow/wasmer 19.2±0.01µs 19.0±0.01µs -1.04%
precise_decimal::pow/wasmer-call-native 2.0±0.00µs 2.0±0.00µs 0.00%
precise_decimal::pow/wasmi 356.9±0.20µs 357.9±0.16µs +0.28%
precise_decimal::pow/wasmi-call-native 7.4±0.03µs 7.6±0.03µs +2.70%
precise_decimal::root/0 63.5±0.02µs 60.8±0.01µs -4.25%
precise_decimal::sub/0 8.3±0.00ns 8.3±0.00ns 0.00%
precise_decimal::to_string/0 741.1±0.13ns 742.1±0.13ns +0.13%
schema::validate_payload 332.6±0.37µs 325.4±0.21µs -2.16%
transaction::radiswap 5.6±0.07ms 5.6±0.07ms 0.00%
transaction::transfer 1715.9±3.97µs 1714.4±6.36µs -0.09%
transaction_processing::prepare 2.4±0.01ms 2.4±0.00ms 0.00%
transaction_processing::prepare_and_decompile 6.3±0.03ms 6.3±0.01ms 0.00%
transaction_processing::prepare_and_decompile_and_recompile 24.0±0.07ms 24.1±0.06ms +0.42%
transaction_validation::validate_manifest 43.9±0.03µs 44.0±0.10µs +0.23%
transaction_validation::verify_bls_2KB 1056.2±23.56µs 1012.0±2.04µs -4.18%
transaction_validation::verify_bls_32B 1014.2±2.56µs 1010.1±2.35µs -0.40%
transaction_validation::verify_ecdsa 78.2±0.09µs 78.2±0.09µs 0.00%
transaction_validation::verify_ed25519 51.4±0.05µs 51.5±0.05µs +0.19%

@talekhinezh talekhinezh merged commit 4840871 into develop Jan 16, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants