Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in substate stores #1683

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Conversation

iamyulong
Copy link
Member

@iamyulong iamyulong commented Jan 17, 2024

Summary

  • Fixed a bug in partition deletion for RocksdbSubstateStore and RocksDBWithMerkleTreeSubstateStore
  • Fixed a bug in list_partition_keys for RocksDBWithMerkleTreeSubstateStore

(The two stores are used by resim and ledger-tools only)

Testing

New tests added.

Copy link

Benchmark for be5e3b4

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 64.6±0.36ms 65.0±0.48ms +0.62%
costing::decode_sbor 13.3±0.04µs 13.1±0.02µs -1.50%
costing::decode_sbor_bytes 35.8±0.10µs 36.6±0.23µs +2.23%
costing::deserialize_wasm 1238.6±1.28µs 1240.6±1.54µs +0.16%
costing::instantiate_flash_loan 4.0±0.56ms 3.8±0.31ms -5.00%
costing::instantiate_radiswap 5.2±0.07ms 5.1±0.07ms -1.92%
costing::spin_loop 21.7±0.02ms 21.5±0.03ms -0.92%
costing::validate_sbor_payload 26.5±0.02µs 26.0±0.03µs -1.89%
costing::validate_sbor_payload_bytes 354.2±0.28ns 355.4±3.94ns +0.34%
costing::validate_secp256k1 80.3±0.08µs 80.3±0.08µs 0.00%
costing::validate_wasm 34.7±0.05ms 34.9±0.07ms +0.58%
decimal::add/0 7.2±0.01ns 7.2±0.01ns 0.00%
decimal::add/rust-native 9.2±0.05ns 9.0±0.11ns -2.17%
decimal::add/wasmer 137.1±0.06ns 136.7±0.06ns -0.29%
decimal::add/wasmer-call-native 549.0±0.19ns 517.2±0.32ns -5.79%
decimal::add/wasmi 440.4±0.08ns 438.6±0.05ns -0.41%
decimal::add/wasmi-call-native 3.3±0.01µs 3.3±0.01µs 0.00%
decimal::div/0 164.6±0.04ns 165.5±0.05ns +0.55%
decimal::from_string/0 153.9±0.09ns 153.6±0.13ns -0.19%
decimal::mul/0 127.8±0.08ns 128.7±0.06ns +0.70%
decimal::mul/rust-native 131.3±0.09ns 131.3±0.06ns 0.00%
decimal::mul/wasmer 1717.1±0.54ns 1731.2±2.39ns +0.82%
decimal::mul/wasmer-call-native 653.1±0.27ns 653.1±0.66ns 0.00%
decimal::mul/wasmi 27.1±0.02µs 26.5±0.03µs -2.21%
decimal::mul/wasmi-call-native 3.5±0.01µs 3.6±0.02µs +2.86%
decimal::pow/0 621.4±0.20ns 621.2±0.19ns -0.03%
decimal::pow/rust-native 618.1±0.30ns 606.9±0.30ns -1.81%
decimal::pow/wasmer 7.5±0.00µs 7.5±0.00µs 0.00%
decimal::pow/wasmer-call-native 1087.2±0.30ns 1077.7±0.49ns -0.87%
decimal::pow/wasmi 127.6±0.05µs 127.6±0.06µs 0.00%
decimal::pow/wasmi-call-native 3.4±0.02µs 3.4±0.01µs 0.00%
decimal::root/0 9.1±0.00µs 9.1±0.01µs 0.00%
decimal::sub/0 7.2±0.00ns 7.2±0.00ns 0.00%
decimal::to_string/0 491.5±0.26ns 493.5±0.10ns +0.41%
precise_decimal::add/0 8.0±0.00ns 8.0±0.00ns 0.00%
precise_decimal::add/rust-native 10.2±0.02ns 10.3±0.04ns +0.98%
precise_decimal::add/wasmer 140.0±0.04ns 139.0±0.04ns -0.71%
precise_decimal::add/wasmer-call-native 535.3±0.16ns 533.3±0.13ns -0.37%
precise_decimal::add/wasmi 526.8±0.10ns 525.7±0.11ns -0.21%
precise_decimal::add/wasmi-call-native 3.6±0.01µs 3.6±0.01µs 0.00%
precise_decimal::div/0 277.3±0.07ns 264.5±0.08ns -4.62%
precise_decimal::from_string/0 194.5±0.27ns 198.6±0.17ns +2.11%
precise_decimal::mul/0 295.9±0.10ns 284.1±0.08ns -3.99%
precise_decimal::mul/rust-native 265.2±0.31ns 263.3±0.04ns -0.72%
precise_decimal::mul/wasmer 4.0±0.00µs 4.1±0.00µs +2.50%
precise_decimal::mul/wasmer-call-native 832.6±0.18ns 828.6±2.66ns -0.48%
precise_decimal::mul/wasmi 74.2±0.02µs 73.9±0.03µs -0.40%
precise_decimal::mul/wasmi-call-native 3.9±0.01µs 3.9±0.01µs 0.00%
precise_decimal::pow/0 1591.5±1.64ns 1573.2±0.71ns -1.15%
precise_decimal::pow/rust-native 1273.5±0.31ns 1273.8±0.55ns +0.02%
precise_decimal::pow/wasmer 19.0±0.01µs 19.0±0.02µs 0.00%
precise_decimal::pow/wasmer-call-native 2.0±0.00µs 2.0±0.00µs 0.00%
precise_decimal::pow/wasmi 358.1±0.11µs 357.2±0.23µs -0.25%
precise_decimal::pow/wasmi-call-native 7.6±0.03µs 7.6±0.02µs 0.00%
precise_decimal::root/0 60.9±0.03µs 60.1±0.15µs -1.31%
precise_decimal::sub/0 8.3±0.00ns 8.3±0.00ns 0.00%
precise_decimal::to_string/0 742.4±0.16ns 741.0±0.24ns -0.19%
schema::validate_payload 324.6±0.27µs 332.8±2.95µs +2.53%
transaction::radiswap 5.2±0.04ms 5.1±0.04ms -1.92%
transaction::transfer 1692.2±4.48µs 1687.1±2.77µs -0.30%
transaction_processing::prepare 2.4±0.00ms 2.4±0.00ms 0.00%
transaction_processing::prepare_and_decompile 6.2±0.01ms 6.2±0.01ms 0.00%
transaction_processing::prepare_and_decompile_and_recompile 23.0±0.24ms 23.2±0.15ms +0.87%
transaction_validation::validate_manifest 43.9±0.04µs 43.9±0.56µs 0.00%
transaction_validation::verify_bls_2KB 1023.6±15.51µs 1000.2±0.81µs -2.29%
transaction_validation::verify_bls_32B 1000.4±1.81µs 1024.3±11.28µs +2.39%
transaction_validation::verify_ecdsa 78.1±0.06µs 78.1±0.12µs 0.00%
transaction_validation::verify_ed25519 51.7±0.17µs 51.5±0.08µs -0.39%

Copy link
Contributor

@mstrug-rdx mstrug-rdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

@talekhinezh talekhinezh merged commit 8219fd5 into develop Jan 17, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants