Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix manifest builder complex deposit batch bug #1702

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

dhedey
Copy link
Contributor

@dhedey dhedey commented Jan 30, 2024

Summary

Small bug fix to enable the test case which I've added. Thanks to Michal for the report.

Copy link

Benchmark for 26a21c4

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 78.9±0.15ms 78.4±0.10ms -0.63%
costing::decode_sbor 18.5±0.07µs 18.4±0.06µs -0.54%
costing::decode_sbor_bytes 43.0±0.17µs 42.8±0.08µs -0.47%
costing::deserialize_wasm 1627.2±8.87µs 1620.6±2.78µs -0.41%
costing::instantiate_flash_loan 4.9±1.08ms 5.1±1.20ms +4.08%
costing::instantiate_radiswap 6.8±0.05ms 6.8±0.05ms 0.00%
costing::spin_loop 26.3±0.06ms 26.4±0.14ms +0.38%
costing::validate_sbor_payload 33.4±0.04µs 33.0±0.14µs -1.20%
costing::validate_sbor_payload_bytes 449.9±0.85ns 431.5±1.49ns -4.09%
costing::validate_secp256k1 96.5±0.08µs 96.5±0.21µs 0.00%
costing::validate_wasm 44.9±0.07ms 44.9±0.03ms 0.00%
decimal::add/0 9.9±0.03ns 9.9±0.03ns 0.00%
decimal::add/rust-native 10.7±0.00ns 10.8±0.01ns +0.93%
decimal::add/wasmer 167.6±0.07ns 169.8±0.18ns +1.31%
decimal::add/wasmer-call-native 561.0±2.53ns 572.9±2.12ns +2.12%
decimal::add/wasmi 560.7±1.21ns 567.6±1.87ns +1.23%
decimal::add/wasmi-call-native 5.0±0.02µs 5.0±0.01µs 0.00%
decimal::div/0 210.6±0.46ns 205.4±0.52ns -2.47%
decimal::from_string/0 198.3±1.02ns 201.7±0.44ns +1.71%
decimal::mul/0 178.8±0.32ns 178.0±0.17ns -0.45%
decimal::mul/rust-native 160.0±0.22ns 162.8±1.09ns +1.75%
decimal::mul/wasmer 1803.3±4.17ns 1800.1±3.28ns -0.18%
decimal::mul/wasmer-call-native 739.2±1.49ns 735.5±1.63ns -0.50%
decimal::mul/wasmi 37.4±0.14µs 37.1±0.04µs -0.80%
decimal::mul/wasmi-call-native 5.3±0.01µs 5.3±0.01µs 0.00%
decimal::pow/0 802.5±1.90ns 794.0±0.95ns -1.06%
decimal::pow/rust-native 753.4±0.89ns 754.6±1.32ns +0.16%
decimal::pow/wasmer 7.9±0.01µs 7.8±0.01µs -1.27%
decimal::pow/wasmer-call-native 1253.0±3.56ns 1245.2±1.45ns -0.62%
decimal::pow/wasmi 175.1±0.31µs 172.0±0.24µs -1.77%
decimal::pow/wasmi-call-native 5.6±0.03µs 5.7±0.04µs +1.79%
decimal::root/0 11.4±0.03µs 11.4±0.01µs 0.00%
decimal::sub/0 9.8±0.03ns 9.8±0.03ns 0.00%
decimal::to_string/0 917.6±1.82ns 922.5±1.44ns +0.53%
precise_decimal::add/0 11.0±0.00ns 11.0±0.01ns 0.00%
precise_decimal::add/rust-native 12.6±0.01ns 12.7±0.02ns +0.79%
precise_decimal::add/wasmer 181.6±0.15ns 181.4±0.09ns -0.11%
precise_decimal::add/wasmer-call-native 586.0±1.00ns 586.9±1.92ns +0.15%
precise_decimal::add/wasmi 747.0±4.12ns 740.8±3.50ns -0.83%
precise_decimal::add/wasmi-call-native 5.8±0.01µs 5.7±0.02µs -1.72%
precise_decimal::div/0 318.5±0.41ns 326.4±0.27ns +2.48%
precise_decimal::from_string/0 253.4±0.46ns 256.0±1.31ns +1.03%
precise_decimal::mul/0 355.3±0.79ns 365.9±1.29ns +2.98%
precise_decimal::mul/rust-native 314.1±0.42ns 313.8±0.57ns -0.10%
precise_decimal::mul/wasmer 4.2±0.01µs 4.2±0.00µs 0.00%
precise_decimal::mul/wasmer-call-native 913.4±2.14ns 899.0±1.63ns -1.58%
precise_decimal::mul/wasmi 93.3±0.25µs 92.1±0.07µs -1.29%
precise_decimal::mul/wasmi-call-native 6.1±0.01µs 6.1±0.01µs 0.00%
precise_decimal::pow/0 1947.5±2.78ns 1953.9±4.95ns +0.33%
precise_decimal::pow/rust-native 1567.4±2.59ns 1568.6±1.08ns +0.08%
precise_decimal::pow/wasmer 19.9±0.04µs 19.8±0.04µs -0.50%
precise_decimal::pow/wasmer-call-native 2.3±0.00µs 2.3±0.00µs 0.00%
precise_decimal::pow/wasmi 450.8±0.61µs 448.4±0.74µs -0.53%
precise_decimal::pow/wasmi-call-native 11.9±0.02µs 11.8±0.05µs -0.84%
precise_decimal::root/0 73.3±0.05µs 73.6±0.05µs +0.41%
precise_decimal::sub/0 11.1±0.01ns 11.0±0.01ns -0.90%
precise_decimal::to_string/0 1317.4±2.04ns 1310.7±1.98ns -0.51%
schema::validate_payload 398.0±0.64µs 406.0±0.50µs +2.01%
transaction::radiswap 6.2±0.05ms 6.2±0.02ms 0.00%
transaction::transfer 2.1±0.00ms 2.0±0.00ms -4.76%
transaction_processing::prepare 2.9±0.01ms 3.1±0.01ms +6.90%
transaction_processing::prepare_and_decompile 8.3±0.02ms 8.1±0.02ms -2.41%
transaction_processing::prepare_and_decompile_and_recompile 28.2±0.10ms 28.6±0.07ms +1.42%
transaction_validation::validate_manifest 52.5±0.10µs 52.9±0.12µs +0.76%
transaction_validation::verify_bls_2KB 1115.8±11.99µs 1121.6±43.76µs +0.52%
transaction_validation::verify_bls_32B 1129.9±46.98µs 1110.8±4.38µs -1.69%
transaction_validation::verify_ecdsa 93.1±0.13µs 93.8±0.09µs +0.75%
transaction_validation::verify_ed25519 67.2±0.07µs 67.0±0.07µs -0.30%

Copy link
Contributor

@mstrug-rdx mstrug-rdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

@dhedey dhedey merged commit f96c087 into develop Jan 31, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants