Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCRY-558 rename virtual account #2 #1828

Merged
merged 4 commits into from
May 30, 2024

Conversation

mstrug-rdx
Copy link
Contributor

@mstrug-rdx mstrug-rdx commented May 29, 2024

Summary

Renamed EntityType::GlobalVirtual*Account to EntityType::GlobalPreallocated*Account and EntityType::GlobalVirtual*Identity to EntityType::GlobalPreallocated*Identity.
Updated blueprint constant names.

This is 2nd part of task SCRY-558, 1st PR: #1823.

Copy link

github-actions bot commented May 29, 2024

Docker tags
docker.io/radixdlt/private-scrypto-builder:8e0397209f

Copy link

github-actions bot commented May 29, 2024

Benchmark for 8e03972

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 66.0±0.41ms 65.9±0.17ms -0.15%
costing::decode_sbor 11.0±0.09µs 11.0±0.04µs 0.00%
costing::decode_sbor_bytes 30.2±0.11µs 29.8±0.07µs -1.32%
costing::deserialize_wasm 1324.5±6.60µs 1315.9±6.46µs -0.65%
costing::instantiate_flash_loan 3.8±0.55ms 3.8±0.49ms 0.00%
costing::instantiate_radiswap 5.7±0.05ms 5.9±0.07ms +3.51%
costing::spin_loop 21.5±0.05ms 21.5±0.03ms 0.00%
costing::validate_sbor_payload 27.5±0.08µs 26.1±0.06µs -5.09%
costing::validate_sbor_payload_bytes 238.2±0.90ns 231.2±2.86ns -2.94%
costing::validate_secp256k1 76.9±0.17µs 76.7±0.10µs -0.26%
costing::validate_wasm 36.9±0.06ms 36.9±0.07ms 0.00%
decimal::add/0 8.4±0.01ns 8.4±0.01ns 0.00%
decimal::add/rust-native 9.9±0.03ns 9.9±0.01ns 0.00%
decimal::add/wasmer 115.6±0.32ns 112.4±0.24ns -2.77%
decimal::add/wasmer-call-native 458.4±0.68ns 452.0±0.84ns -1.40%
decimal::add/wasmi 583.8±2.58ns 618.3±1.96ns +5.91%
decimal::add/wasmi-call-native 5.9±0.03µs 5.2±0.01µs -11.86%
decimal::div/0 191.6±0.30ns 191.3±0.27ns -0.16%
decimal::from_string/0 154.5±0.14ns 154.8±1.12ns +0.19%
decimal::mul/0 143.4±0.26ns 142.7±0.45ns -0.49%
decimal::mul/rust-native 137.2±0.39ns 137.4±0.60ns +0.15%
decimal::mul/wasmer 1482.6±3.30ns 1493.5±1.49ns +0.74%
decimal::mul/wasmer-call-native 583.6±2.16ns 583.1±0.74ns -0.09%
decimal::mul/wasmi 42.0±0.08µs 42.8±0.08µs +1.90%
decimal::mul/wasmi-call-native 5.9±0.03µs 5.3±0.01µs -10.17%
decimal::pow/0 668.4±0.89ns 653.1±0.97ns -2.29%
decimal::pow/rust-native 631.6±0.53ns 630.3±0.44ns -0.21%
decimal::pow/wasmer 6.7±0.02µs 6.6±0.00µs -1.49%
decimal::pow/wasmer-call-native 1035.1±3.70ns 1028.0±1.51ns -0.69%
decimal::pow/wasmi 202.1±1.33µs 198.7±0.28µs -1.68%
decimal::pow/wasmi-call-native 5.8±0.06µs 5.5±0.01µs -5.17%
decimal::root/0 7.8±0.01µs 7.8±0.02µs 0.00%
decimal::sub/0 8.5±0.01ns 8.5±0.01ns 0.00%
decimal::to_string/0 449.7±2.12ns 437.1±0.72ns -2.80%
precise_decimal::add/0 9.5±0.08ns 9.5±0.16ns 0.00%
precise_decimal::add/rust-native 11.5±0.02ns 11.5±0.01ns 0.00%
precise_decimal::add/wasmer 116.8±0.44ns 117.9±0.27ns +0.94%
precise_decimal::add/wasmer-call-native 499.6±2.41ns 494.5±0.62ns -1.02%
precise_decimal::add/wasmi 776.6±4.39ns 813.7±1.49ns +4.78%
precise_decimal::add/wasmi-call-native 7.4±0.03µs 6.7±0.06µs -9.46%
precise_decimal::div/0 301.7±0.48ns 303.8±0.38ns +0.70%
precise_decimal::from_string/0 201.2±0.55ns 201.5±0.75ns +0.15%
precise_decimal::mul/0 374.1±2.94ns 345.4±0.36ns -7.67%
precise_decimal::mul/rust-native 304.8±0.81ns 304.3±0.42ns -0.16%
precise_decimal::mul/wasmer 3.5±0.01µs 3.5±0.00µs 0.00%
precise_decimal::mul/wasmer-call-native 802.4±1.75ns 807.3±1.08ns +0.61%
precise_decimal::mul/wasmi 107.2±0.34µs 106.6±0.22µs -0.56%
precise_decimal::mul/wasmi-call-native 7.7±0.05µs 7.3±0.03µs -5.19%
precise_decimal::pow/0 1964.8±4.51ns 1861.0±4.47ns -5.28%
precise_decimal::pow/rust-native 1473.5±3.84ns 1478.6±2.56ns +0.35%
precise_decimal::pow/wasmer 16.2±0.01µs 16.3±0.03µs +0.62%
precise_decimal::pow/wasmer-call-native 2.1±0.01µs 2.1±0.00µs 0.00%
precise_decimal::pow/wasmi 518.7±1.33µs 516.0±1.41µs -0.52%
precise_decimal::pow/wasmi-call-native 13.4±0.04µs 13.5±0.06µs +0.75%
precise_decimal::root/0 56.1±0.08µs 57.1±0.04µs +1.78%
precise_decimal::sub/0 9.4±0.03ns 9.6±0.05ns +2.13%
precise_decimal::to_string/0 726.8±1.27ns 730.3±4.24ns +0.48%
schema::validate_payload 357.5±1.27µs 343.7±0.42µs -3.86%
transaction::radiswap 5.4±0.03ms 5.5±0.02ms +1.85%
transaction::transfer 1776.2±3.05µs 1816.3±6.00µs +2.26%
transaction_processing::prepare 2.3±0.00ms 2.2±0.00ms -4.35%
transaction_processing::prepare_and_decompile 6.0±0.02ms 6.2±0.01ms +3.33%
transaction_processing::prepare_and_decompile_and_recompile 24.4±0.67ms 24.6±1.07ms +0.82%
transaction_validation::validate_manifest 42.4±0.15µs 42.4±0.06µs 0.00%
transaction_validation::verify_bls_2KB 1005.2±15.41µs 1001.2±6.85µs -0.40%
transaction_validation::verify_bls_32B 1057.5±16.61µs 1003.1±7.79µs -5.14%
transaction_validation::verify_ecdsa 74.8±0.24µs 74.8±0.11µs 0.00%
transaction_validation::verify_ed25519 55.5±0.11µs 55.3±0.23µs -0.36%

@mstrug-rdx mstrug-rdx changed the title Renamed EntityType GlobalVirtualAccount to GlobalPreallocatedAccount SCRY-558 rename virtual account #2 May 29, 2024
@mstrug-rdx mstrug-rdx marked this pull request as ready for review May 29, 2024 22:27
@iamyulong iamyulong changed the base branch from refactor/SCRY-558-rename-virtual to develop May 30, 2024 08:49
Copy link
Member

@iamyulong iamyulong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mstrug-rdx mstrug-rdx merged commit 63d11ec into develop May 30, 2024
29 checks passed
@mstrug-rdx mstrug-rdx deleted the refactor/SCRY-558-rename-virtual-entity branch June 12, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants