Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation/add more book content #1831

Merged
merged 9 commits into from
Jun 10, 2024

Conversation

talekhinezh
Copy link
Member

  • Expand on System Layer Documentation

Copy link

github-actions bot commented Jun 3, 2024

Docker tags
docker.io/radixdlt/private-scrypto-builder:ded79042e8

Copy link

github-actions bot commented Jun 3, 2024

Benchmark for ded7904

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 65.8±0.37ms 65.8±0.15ms 0.00%
costing::decode_sbor 11.1±0.05µs 11.1±0.01µs 0.00%
costing::decode_sbor_bytes 29.6±0.03µs 29.6±0.07µs 0.00%
costing::deserialize_wasm 1318.3±3.69µs 1308.1±8.79µs -0.77%
costing::instantiate_flash_loan 4.2±0.87ms 3.9±0.64ms -7.14%
costing::instantiate_radiswap 5.6±0.04ms 5.7±0.06ms +1.79%
costing::spin_loop 21.6±0.06ms 22.5±0.56ms +4.17%
costing::validate_sbor_payload 27.5±0.23µs 27.5±0.03µs 0.00%
costing::validate_sbor_payload_bytes 237.0±2.58ns 242.1±0.68ns +2.15%
costing::validate_secp256k1 76.3±0.05µs 76.3±0.09µs 0.00%
costing::validate_wasm 36.5±0.03ms 36.6±0.03ms +0.27%
decimal::add/0 8.4±0.00ns 8.5±0.10ns +1.19%
decimal::add/rust-native 9.8±0.00ns 9.8±0.00ns 0.00%
decimal::add/wasmer 110.7±0.09ns 110.5±0.07ns -0.18%
decimal::add/wasmer-call-native 451.7±0.88ns 453.6±0.34ns +0.42%
decimal::add/wasmi 623.7±1.20ns 620.8±1.21ns -0.46%
decimal::add/wasmi-call-native 5.2±0.02µs 5.3±0.01µs +1.92%
decimal::div/0 191.2±0.16ns 191.8±0.17ns +0.31%
decimal::from_string/0 151.4±0.22ns 151.3±0.09ns -0.07%
decimal::mul/0 142.7±0.14ns 142.0±0.25ns -0.49%
decimal::mul/rust-native 135.8±0.27ns 138.3±0.23ns +1.84%
decimal::mul/wasmer 1529.2±0.91ns 1496.0±0.89ns -2.17%
decimal::mul/wasmer-call-native 576.6±0.41ns 582.6±0.42ns +1.04%
decimal::mul/wasmi 42.6±0.08µs 45.5±0.06µs +6.81%
decimal::mul/wasmi-call-native 5.4±0.01µs 5.4±0.01µs 0.00%
decimal::pow/0 650.7±1.01ns 656.5±0.80ns +0.89%
decimal::pow/rust-native 636.8±1.57ns 638.0±1.72ns +0.19%
decimal::pow/wasmer 6.7±0.00µs 6.9±0.01µs +2.99%
decimal::pow/wasmer-call-native 1030.8±0.75ns 1024.6±0.41ns -0.60%
decimal::pow/wasmi 201.2±0.56µs 200.4±0.40µs -0.40%
decimal::pow/wasmi-call-native 5.2±0.04µs 5.2±0.01µs 0.00%
decimal::root/0 7.8±0.02µs 7.9±0.01µs +1.28%
decimal::sub/0 8.5±0.01ns 8.5±0.01ns 0.00%
decimal::to_string/0 462.1±0.19ns 434.0±0.76ns -6.08%
precise_decimal::add/0 9.3±0.07ns 9.4±0.07ns +1.08%
precise_decimal::add/rust-native 11.4±0.00ns 11.4±0.00ns 0.00%
precise_decimal::add/wasmer 113.9±0.14ns 113.6±0.09ns -0.26%
precise_decimal::add/wasmer-call-native 499.1±0.30ns 503.6±0.47ns +0.90%
precise_decimal::add/wasmi 798.4±1.40ns 792.0±0.93ns -0.80%
precise_decimal::add/wasmi-call-native 6.8±0.02µs 6.9±0.01µs +1.47%
precise_decimal::div/0 301.3±0.50ns 303.3±0.25ns +0.66%
precise_decimal::from_string/0 196.0±0.31ns 196.2±0.20ns +0.10%
precise_decimal::mul/0 360.4±5.46ns 346.8±1.12ns -3.77%
precise_decimal::mul/rust-native 322.5±2.22ns 316.1±1.96ns -1.98%
precise_decimal::mul/wasmer 3.4±0.00µs 3.4±0.00µs 0.00%
precise_decimal::mul/wasmer-call-native 812.8±1.95ns 808.7±1.71ns -0.50%
precise_decimal::mul/wasmi 107.4±0.35µs 108.4±0.14µs +0.93%
precise_decimal::mul/wasmi-call-native 7.3±0.03µs 7.4±0.01µs +1.37%
precise_decimal::pow/0 1854.1±2.12ns 1850.7±4.68ns -0.18%
precise_decimal::pow/rust-native 1485.0±2.18ns 1481.3±1.77ns -0.25%
precise_decimal::pow/wasmer 16.1±0.01µs 16.0±0.00µs -0.62%
precise_decimal::pow/wasmer-call-native 2.1±0.00µs 2.1±0.00µs 0.00%
precise_decimal::pow/wasmi 529.4±1.17µs 519.6±1.12µs -1.85%
precise_decimal::pow/wasmi-call-native 13.4±0.07µs 13.3±0.04µs -0.75%
precise_decimal::root/0 56.7±0.07µs 56.7±0.03µs 0.00%
precise_decimal::sub/0 9.5±0.01ns 9.5±0.00ns 0.00%
precise_decimal::to_string/0 725.0±0.61ns 716.1±0.73ns -1.23%
schema::validate_payload 355.5±0.44µs 342.1±0.36µs -3.77%
transaction::radiswap 5.3±0.03ms 5.3±0.02ms 0.00%
transaction::transfer 1748.2±7.92µs 1757.5±3.69µs +0.53%
transaction_processing::prepare 2.2±0.00ms 2.3±0.00ms +4.55%
transaction_processing::prepare_and_decompile 6.0±0.01ms 6.0±0.03ms 0.00%
transaction_processing::prepare_and_decompile_and_recompile 24.1±0.42ms 24.0±0.11ms -0.41%
transaction_validation::validate_manifest 42.1±0.04µs 42.1±0.06µs 0.00%
transaction_validation::verify_bls_2KB 1023.5±112.74µs 1050.2±114.49µs +2.61%
transaction_validation::verify_bls_32B 960.9±8.14µs 980.3±12.94µs +2.02%
transaction_validation::verify_ecdsa 74.2±0.14µs 74.2±0.05µs 0.00%
transaction_validation::verify_ed25519 54.8±0.11µs 54.9±0.06µs +0.18%

@@ -6,6 +6,6 @@ the Blueprint. This includes:
* Function Input/Output
* Events

The Type Checking System supports generics.
The Schema Checking System supports generics.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly prefer to the previous word. Schema checking gives me the impression that we're checking the validity of schema (which is part of SBOR schema terminology)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

@talekhinezh talekhinezh merged commit 893a06f into develop Jun 10, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants