Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "pass the current depth as an argument to modules" #1842

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

0xOmarA
Copy link
Member

@0xOmarA 0xOmarA commented Jun 28, 2024

This reverts commit 50ab8d2.

Copy link

github-actions bot commented Jun 28, 2024

Docker tags
docker.io/radixdlt/private-scrypto-builder:7f033c87ea

Copy link

github-actions bot commented Jun 28, 2024

Benchmark for 7f033c8

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 65.5±0.16ms 65.7±0.17ms +0.31%
costing::decode_sbor 10.8±0.02µs 10.8±0.01µs 0.00%
costing::decode_sbor_bytes 29.2±0.07µs 29.2±0.10µs 0.00%
costing::deserialize_wasm 1285.5±18.48µs 1284.9±4.26µs -0.05%
costing::instantiate_flash_loan 3.9±0.74ms 4.1±0.85ms +5.13%
costing::instantiate_radiswap 5.7±0.07ms 5.6±0.05ms -1.75%
costing::spin_loop 21.5±0.04ms 21.6±0.03ms +0.47%
costing::validate_sbor_payload 27.5±0.07µs 26.1±0.05µs -5.09%
costing::validate_sbor_payload_bytes 238.7±0.91ns 227.1±0.63ns -4.86%
costing::validate_secp256k1 76.2±0.04µs 76.2±0.04µs 0.00%
costing::validate_wasm 36.7±0.04ms 36.4±0.04ms -0.82%
decimal::add/0 8.4±0.00ns 8.4±0.00ns 0.00%
decimal::add/rust-native 9.8±0.00ns 9.8±0.00ns 0.00%
decimal::add/wasmer 115.2±0.17ns 114.5±0.20ns -0.61%
decimal::add/wasmer-call-native 447.6±0.34ns 447.0±0.36ns -0.13%
decimal::add/wasmi 612.6±3.36ns 606.4±4.57ns -1.01%
decimal::add/wasmi-call-native 5.3±0.01µs 5.1±0.01µs -3.77%
decimal::div/0 195.4±0.16ns 190.9±0.03ns -2.30%
decimal::from_string/0 153.7±0.37ns 153.0±0.28ns -0.46%
decimal::mul/0 140.4±0.16ns 141.1±0.17ns +0.50%
decimal::mul/rust-native 134.9±0.32ns 134.7±0.19ns -0.15%
decimal::mul/wasmer 1501.8±0.72ns 1503.2±0.48ns +0.09%
decimal::mul/wasmer-call-native 576.2±0.56ns 577.0±0.40ns +0.14%
decimal::mul/wasmi 41.2±0.16µs 40.2±0.36µs -2.43%
decimal::mul/wasmi-call-native 5.5±0.03µs 5.2±0.01µs -5.45%
decimal::pow/0 655.6±0.59ns 651.0±1.31ns -0.70%
decimal::pow/rust-native 631.0±0.61ns 630.8±1.03ns -0.03%
decimal::pow/wasmer 6.6±0.01µs 6.6±0.01µs 0.00%
decimal::pow/wasmer-call-native 1015.9±0.43ns 1022.2±0.41ns +0.62%
decimal::pow/wasmi 192.1±0.46µs 189.2±0.70µs -1.51%
decimal::pow/wasmi-call-native 5.3±0.01µs 5.0±0.01µs -5.66%
decimal::root/0 7.7±0.01µs 8.0±0.01µs +3.90%
decimal::sub/0 8.5±0.01ns 8.5±0.01ns 0.00%
decimal::to_string/0 465.4±1.40ns 444.8±0.91ns -4.43%
precise_decimal::add/0 9.3±0.01ns 9.3±0.01ns 0.00%
precise_decimal::add/rust-native 11.4±0.00ns 11.4±0.00ns 0.00%
precise_decimal::add/wasmer 126.9±0.04ns 127.4±0.31ns +0.39%
precise_decimal::add/wasmer-call-native 507.0±0.45ns 510.9±0.88ns +0.77%
precise_decimal::add/wasmi 781.9±4.65ns 760.3±5.08ns -2.76%
precise_decimal::add/wasmi-call-native 6.9±0.03µs 6.6±0.02µs -4.35%
precise_decimal::div/0 303.1±0.34ns 300.1±0.27ns -0.99%
precise_decimal::from_string/0 198.6±0.24ns 198.7±0.31ns +0.05%
precise_decimal::mul/0 350.8±3.21ns 347.7±1.33ns -0.88%
precise_decimal::mul/rust-native 304.9±0.37ns 305.1±0.94ns +0.07%
precise_decimal::mul/wasmer 3.5±0.00µs 3.5±0.00µs 0.00%
precise_decimal::mul/wasmer-call-native 832.6±2.66ns 830.3±1.93ns -0.28%
precise_decimal::mul/wasmi 104.7±0.47µs 103.4±0.22µs -1.24%
precise_decimal::mul/wasmi-call-native 7.4±0.02µs 7.0±0.02µs -5.41%
precise_decimal::pow/0 1862.1±3.73ns 1860.8±3.68ns -0.07%
precise_decimal::pow/rust-native 1468.8±2.93ns 1476.3±5.31ns +0.51%
precise_decimal::pow/wasmer 16.5±0.01µs 16.2±0.01µs -1.82%
precise_decimal::pow/wasmer-call-native 2.1±0.00µs 2.1±0.01µs 0.00%
precise_decimal::pow/wasmi 505.9±1.42µs 502.3±0.60µs -0.71%
precise_decimal::pow/wasmi-call-native 13.1±0.02µs 12.5±0.06µs -4.58%
precise_decimal::root/0 56.4±0.06µs 56.6±0.03µs +0.35%
precise_decimal::sub/0 9.5±0.01ns 9.5±0.01ns 0.00%
precise_decimal::to_string/0 739.6±2.84ns 723.2±1.76ns -2.22%
schema::validate_payload 344.3±0.40µs 345.1±0.41µs +0.23%
transaction::radiswap 5.3±0.03ms 5.5±0.03ms +3.77%
transaction::transfer 1763.8±8.17µs 1750.4±9.49µs -0.76%
transaction_processing::prepare 2.2±0.00ms 2.2±0.00ms 0.00%
transaction_processing::prepare_and_decompile 6.2±0.03ms 6.0±0.02ms -3.23%
transaction_processing::prepare_and_decompile_and_recompile 24.2±0.47ms 25.8±2.14ms +6.61%
transaction_validation::validate_manifest 42.2±0.03µs 42.3±0.58µs +0.24%
transaction_validation::verify_bls_2KB 958.5±9.42µs 1012.7±41.75µs +5.65%
transaction_validation::verify_bls_32B 959.2±6.82µs 1057.5±80.30µs +10.25%
transaction_validation::verify_ecdsa 74.4±0.70µs 74.4±0.75µs 0.00%
transaction_validation::verify_ed25519 54.9±0.06µs 55.0±0.75µs +0.18%

@0xOmarA 0xOmarA merged commit 44fac79 into develop Jul 2, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants