permit external URL resolution for images #32
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual code uses the
url.openStream()
, which doesn't give too much options to control how to obtain the image (from a local file, for example). This change allows the user to manipulate how to load URL images. The requirement is to create a subclass ofURLResolver
and itsresolve
method, returning the actualInputStream
from the given url.The
URLResolver
instance is found as aBrowserConfig
's property.