Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor beats to match model from beat-generator and exit param #7

Closed
radoondas opened this issue Jan 29, 2016 · 3 comments
Closed

Refactor beats to match model from beat-generator and exit param #7

radoondas opened this issue Jan 29, 2016 · 3 comments
Assignees
@radoondas
Labels
bug

Comments

@radoondas
Copy link
Owner

Ref - elastic/beats#864
@radoondas radoondas added the bug label Jan 29, 2016
@radoondas radoondas self-assigned this Jan 29, 2016
@radoondas
Copy link
Owner Author

@ruflin: would you mind to have a look if I got it right? all my tests and functionality is working perfectly. Hope, I didn't overlook anything. Thanks a lot for your time. :)

@ruflin
Copy link

ruflin commented Jan 31, 2016

@radoondas LGTM. I would recommend to also update the Makefile with the reference to the libbeat Makefile. This will make the generation of the elasticbeat.yml file easy (and other functions are directly available).

@radoondas
Copy link
Owner Author

@ruflin Thanks a lot! I'll also reflect Makefile changes. Thanks for the point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radoondas radoondas

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ruflin @radoondas